Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 983b7b85d122
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b6723e33b858
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Nov 19, 2024

  1. Add missing cancellable to text input handler (#56666) 

    Without this if a channel method call was in progress and then the
handler was destroyed the call could attempt to access the destroyed
handler. This is possible as the handler is recreated on engine restart.

However, in this case the result is not used so no invalid memory access
would occur. Adding the cancellable fixes any future change where this
would no longer be the case.
    @robert-ancell
    robert-ancell authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cc8f069 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 8d652f142911 to 17601e471acf (1 revision) (#56696) 

    https://skia.googlesource.com/skia.git/+log/8d652f142911..17601e471acf

2024-11-19 [email protected] Roll vulkan-deps from 59ce475cae66 to 824ef0f736ed (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    0ec3087 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 17601e471acf to 8a1a84509501 (4 revisions) (#56700) 

    https://skia.googlesource.com/skia.git/+log/17601e471acf..8a1a84509501

2024-11-19 [email protected] Roll SwiftShader from 4d3a7b64279f to 4074d9674b3e (1 revision)
2024-11-19 [email protected] Roll Skia Infra from 523dc313e7a2 to b51256461a37 (5 revisions)
2024-11-19 [email protected] [rust png] Fix -Wprivate-header warning for raster pipeline headers.
2024-11-19 [email protected] Roll Dawn from 3fc6432bcc2f to 6898ea1d553e (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    b6723e3 View commit details
    Browse the repository at this point in the history
Loading