Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 965501a25d92
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b8ec4da8866c
Choose a head ref
  • 11 commits
  • 23 files changed
  • 5 contributors

Commits on Aug 24, 2023

  1. Roll Skia from b17ee34f3378 to 007386294889 (1 revision) (#45075) 

    https://skia.googlesource.com/skia.git/+log/b17ee34f3378..007386294889

2023-08-24 [email protected] Remove support for Dawn in Ganesh.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    cd9e5fc View commit details
    Browse the repository at this point in the history

  2. Turn on the skia_enable_optimize_size flag to save a bit of binary … 

    …size (#45029)

This flag removes some code from CanvasKit to reduce size by a little bit. I went ahead and did a run of the benchmarks (flutter/flutter#133208) to see if it negatively affected anything, and there was no difference beyond noise between the current benchmark numbers and the benchmarks with this flag enabled.

The size differences are as follows:
Before the change:
```
total 30616
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:33 .
drwxr-xr-x   7 jacksongardner  primarygroup      224 Aug 10 18:14 ..
-rw-r--r--@  1 jacksongardner  primarygroup     6148 May 12 17:41 .DS_Store
-rw-r--r--   2 jacksongardner  primarygroup    94899 Aug 23 14:23 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  6631693 Aug 23 14:23 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  2102151 Aug 23 14:23 canvaskit.wasm.br
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:33 chromium
-rw-r--r--   2 jacksongardner  primarygroup   161478 Aug 23 14:28 skwasm.js
-rwxr-xr-x   2 jacksongardner  primarygroup  3296038 Aug 23 14:28 skwasm.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1101502 Aug 23 14:28 skwasm.wasm.br
-rw-r--r--   2 jacksongardner  primarygroup     3095 Aug 23 14:28 skwasm.worker.js

./chromium:
total 15520
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:33 .
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:33 ..
-rw-r--r--   2 jacksongardner  primarygroup    94545 Aug 23 14:25 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  5223378 Aug 23 14:25 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1492433 Aug 23 14:25 canvaskit.wasm.br
```

After the change:
```
total 28568
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:42 .
drwxr-xr-x   7 jacksongardner  primarygroup      224 Aug 10 18:14 ..
-rw-r--r--@  1 jacksongardner  primarygroup     6148 May 12 17:41 .DS_Store
-rw-r--r--   2 jacksongardner  primarygroup    94899 Aug 23 14:37 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  6401703 Aug 23 14:37 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  2038390 Aug 23 14:37 canvaskit.wasm.br
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:42 chromium
-rw-r--r--   2 jacksongardner  primarygroup   161478 Aug 23 14:41 skwasm.js
-rwxr-xr-x   2 jacksongardner  primarygroup  3143431 Aug 23 14:41 skwasm.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1050854 Aug 23 14:41 skwasm.wasm.br
-rw-r--r--   2 jacksongardner  primarygroup     3095 Aug 23 14:41 skwasm.worker.js

./chromium:
total 15392
drwxr-xr-x   5 jacksongardner  primarygroup      160 Aug 23 14:42 .
drwxr-xr-x  11 jacksongardner  primarygroup      352 Aug 23 14:42 ..
-rw-r--r--   2 jacksongardner  primarygroup    94545 Aug 23 14:39 canvaskit.js
-rwxr-xr-x   2 jacksongardner  primarygroup  4993586 Aug 23 14:39 canvaskit.wasm
-rwxr-xr-x   1 jacksongardner  primarygroup  1427979 Aug 23 14:39 canvaskit.wasm.br
```

The brotli-compressed wasm modules save about 50-70kb each with this flag.
    @eyebrowsoffire
    eyebrowsoffire authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    143e3f3 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 007386294889 to 177e8477faf9 (1 revision) (#45076) 

    https://skia.googlesource.com/skia.git/+log/007386294889..177e8477faf9

2023-08-24 [email protected] Disable timing-out/flaking tests on Intel Iris Pro + Metal.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    c3f57b7 View commit details
    Browse the repository at this point in the history

  4. Add case checking to android sdk cipd upload script (#45063) 

    See flutter/flutter#131901 (comment) for the reason for this PR.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gmackall
    gmackall authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9db6417 View commit details
    Browse the repository at this point in the history

  5. Reland: [Rasterizer] Make resubmit information temporary (#45037) 

    Relands #42001.

The previous attempt was reverted due to post-submit flakeness, some mysterious crashes. I didn't change anything this time, but now that PR #44973 is merged that fixes some racing issues, I wonder if the crashes of this change are resolved as well.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @dkwingsmt
    dkwingsmt authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    1d0077e View commit details
    Browse the repository at this point in the history

  6. Roll Skia from 177e8477faf9 to d7d56885a49b (1 revision) (#45078) 

    https://skia.googlesource.com/skia.git/+log/177e8477faf9..d7d56885a49b

2023-08-24 [email protected] Factor out ContextType from GrContextFactory.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    6e5ad11 View commit details
    Browse the repository at this point in the history

  7. [Impeller] Do not build scene unless 3d define is true (#45028) 

    Fixes flutter/flutter#133193
    @dnfield
    dnfield authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    415bb28 View commit details
    Browse the repository at this point in the history

  8. Roll Skia from d7d56885a49b to 25fafff5b32c (1 revision) (#45081) 

    https://skia.googlesource.com/skia.git/+log/d7d56885a49b..25fafff5b32c

2023-08-24 [email protected] Move Gaussian blur utility functions into skgpu::BlurUtils

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    ca65a61 View commit details
    Browse the repository at this point in the history

  9. Revert "Turn on the skia_enable_optimize_size flag to save a bit of… 

    … binary size" (#45082)

Reverts #45029

It appears this is causing a regression in the length of time some of our integration tests are taking, causing them to take twice as long, which is causing timeouts in CI. We should revert while we investigate.
    @eyebrowsoffire
    eyebrowsoffire authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    8417a45 View commit details
    Browse the repository at this point in the history

  10. Roll Skia from 25fafff5b32c to 99a76ea8e1b2 (2 revisions) (#45083) 

    https://skia.googlesource.com/skia.git/+log/25fafff5b32c..99a76ea8e1b2

2023-08-24 [email protected] Parameterize ImageAsyncReadPixels by renderability and origin
2023-08-24 [email protected] Revert "Factor out ContextType from GrContextFactory."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    63898d5 View commit details
    Browse the repository at this point in the history

  11. Roll Skia from 99a76ea8e1b2 to 1428f16fc0de (1 revision) (#45086) 

    https://skia.googlesource.com/skia.git/+log/99a76ea8e1b2..1428f16fc0de

2023-08-24 [email protected] [Graphite] Add support for Context and Recorder freeGpuResources call.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b8ec4da View commit details
    Browse the repository at this point in the history
Loading