Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 942d7c35de75
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9e17588b330c
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on May 16, 2024

  1. Reverts "Revamp the engine style guide, remove always_specify_types. ( 

    #52859)" (#52867)

Reverts: #52859
Initiated by: zanderso
Reason for reverting: This sort of change *is* in scope for a discussion at the Dash forum.
Original PR Author: matanlurey

Reviewed By: {cbracken, gaaclarke, johnmccutchan}

This change reverts the following previous change:
Based on the (internal) discussion around converging on using the official Dart style guide, with the exception of the code that gets published under `dart:ui`, as that is user-facing, and we'd like to evolve the code style in conjunction with the framework.

I also took the opportunity to specify more about our style guide use in general, mostly to make it easier to understand our conventions, and also call out known problem areas (notably, our over-use of `shared_ptr` and `auto` in some cases). I am happy to split those up, but it was easier to make the markdown changes at once.

I also took @cbracken and folks advice and clarified directly that explicit types in Dart are _not_ bad (with examples).
    @auto-submit
    auto-submit[bot] authored May 16, 2024
    Configuration menu
    Copy the full SHA
    a620531 View commit details
    Browse the repository at this point in the history

  2. et generates {out}/{buildName} if missing on `et {build|test|quer… 

    …y}` (#52866)

Closes flutter/flutter#148442.

This restores functionality that existed prior in #52832:

- Splits `runGn` to `ensureBuildDir`, which is in practice what it does.
    @matanlurey
    matanlurey authored May 16, 2024
    Configuration menu
    Copy the full SHA
    9e17588 View commit details
    Browse the repository at this point in the history
Loading