Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 91898e397261
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c9381fb8ef4c
Choose a head ref
  • 11 commits
  • 27 files changed
  • 7 contributors

Commits on Feb 28, 2024

  1. Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (#51048) 

    https://skia.googlesource.com/skia.git/+log/d591703635b0..fe34002ee826

2024-02-28 [email protected] Manual roll Dawn from 11b95ad3e8f7 to aa0be6f5777f (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1d1c76d View commit details
    Browse the repository at this point in the history

  2. Add flutter prefix to import (#51042) 

    Internally, the source transformations need the flutter prefix here to
replace the import with an absolute path for the depot.

b/327318241
    @jiahaog
    jiahaog authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    aebac40 View commit details
    Browse the repository at this point in the history

  3. Bump everything to Android 21 (#51032) 

    Followed the linter, got rid of a bunch of version check/guards we don't need anymore.
    @dnfield
    dnfield authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    383e228 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (#51049) 

    https://skia.googlesource.com/skia.git/+log/fe34002ee826..d935943bedcd

2024-02-28 [email protected] [graphite] Minor DrawAtlas cleanup.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    afaa6b1 View commit details
    Browse the repository at this point in the history

  5. When run_tests.py is in --quiet mode, write verbose logs to a file (#… 

    …51029)

This PR causes `run_test.py` to write `info` and higher logs to
`out/run_tests.log` even when `--quiet` is passed. If `--logs-dir` is
also passed, the logs file is copied to that location after all tests
are run.

These flags are added to one invocation on CI to check the correct
behavior.
    @zanderso
    zanderso authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3925945 View commit details
    Browse the repository at this point in the history

  6. Roll Skia from d935943bedcd to 0c294ee206e8 (3 revisions) (#51051) 

    https://skia.googlesource.com/skia.git/+log/d935943bedcd..0c294ee206e8

2024-02-28 [email protected] Fix base frequency of stitched Perlin noise.
2024-02-28 [email protected] Re-enable tracing when building for Android framework
2024-02-28 [email protected] [graphite] Add missing failure callback in QueueManager::addRecording

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    367fc88 View commit details
    Browse the repository at this point in the history

  7. Roll buildroot to 7b537de (#51053) 

    Wraps `$python_path` usages in quotes to support python installations in
directories with spaces.

Fixes: flutter/flutter#143740

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] Machine wash cold.
- [X] Do not iron.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @cbracken
    cbracken authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    2c949da View commit details
    Browse the repository at this point in the history

  8. [Impeller] Fix GL depth state. (#51040) 

    This patch fixes problems with GL depth (in service of
#50856):
* The depth + stencil masks weren't being set prior to clearing.
* When the driver identifies as desktop GL rather than ES, use
`glClearDepth` and `glDepthRange` rather than `glClearDepthf` and
`glDepthRangef`.
    @bdero
    bdero authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6de390b View commit details
    Browse the repository at this point in the history

  9. [Android] update fallback and rendering state to combine impeller + a… 

    …ndroid backend. (#51008)

1. Makes it possible to implement Impeller Vulkan -> Skia fallback.
2. Fixes flutter/flutter#143871
3. Fixes flutter/flutter#143873
4. Work towards flutter/flutter#137798

Combines AndroidRenderingAPI + enable_impeller into a 4 values enum that describes all combinations of rendering behavior: ImpellerVulkan, ImpellerOpenGLES, SkiaOpenGLES, Software. 

Updates the fallback behavior to happen in flutter_main. This allows us to change the value of Settings.enable_impeller to support an Impeller -> Skia fallback.
    Jonah Williams authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    5b60aa5 View commit details
    Browse the repository at this point in the history

  10. Roll Skia from 0c294ee206e8 to 93f245da0097 (2 revisions) (#51055) 

    https://skia.googlesource.com/skia.git/+log/0c294ee206e8..93f245da0097

2024-02-28 [email protected] Use a VMA block size of only 64k
2024-02-28 [email protected] Fix wireframe mode in GrTriangulator.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ce88fbc View commit details
    Browse the repository at this point in the history

  11. Revert "Bump everything to Android 21" (#51056) 

    Reverts #51032

Probably causing some of the failures in flutter/flutter#144326

@johnmccutchan fyi
    @dnfield
    dnfield authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c9381fb View commit details
    Browse the repository at this point in the history
Loading