Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 901b455d0cce
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b1076999807f
Choose a head ref
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Dec 17, 2022

  1. Even though the file is pure C code, it's useful to use a C++ or Obje… 

    …ctive-C++ filename in order to use FML (assertions) in the implementation. (#38365)

Three implementation changes:
* Since the file is now C++, some implicit void* conversions now require
  an explicit cast.
* A malloc/free of a buffer has been replaced with a std::vector.
* An `assert()` was changed to `FML_DCHECK` for consistency with the
  rest of the embedder.

No test changes since there are no semantic changes.

Existing tests are in:
https://github.com/flutter/engine/blob/main/shell/platform/darwin/common/framework/Source/flutter_standard_codec_unittest.mm
    @cbracken
    cbracken authored Dec 17, 2022
    Configuration menu
    Copy the full SHA
    b107699 View commit details
    Browse the repository at this point in the history
Loading