Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 877abb9ad6ff
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08348c9eebcc
Choose a head ref
  • 8 commits
  • 17 files changed
  • 5 contributors

Commits on Nov 12, 2024

  1. [iOS] Fix slider semantics node answer to accessibility activate (#56427 

    )

## Description

iOS fix [[A11y] Double Tap brings the Slider thumb to the center of the widget.](flutter/flutter#156427) per instruction from flutter/flutter#157601 (comment)

I don't have a physical iOS device to double check, but using the iOS Simulator and accessibility tools, the behavior seems ok. Without this PR, the slider thumb goes to the center when clicking 'Activate', with this PR it does not :

https://github.com/user-attachments/assets/697acadd-7fb1-40a5-ba5a-b549cac381a1

## Related Issue

iOS fix for [[A11y] Double Tap brings the Slider thumb to the center of the widget.](flutter/flutter#156427)

## Tests

Adds 1 test.
    @bleroux
    bleroux authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9efc25d View commit details
    Browse the repository at this point in the history

  2. [Impeller] In canvas_unittests, only create an MSAA offscreen texture… 

    … if the platform supports MSAA (#56542)
    @jason-simmons
    jason-simmons authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    289a3fb View commit details
    Browse the repository at this point in the history

  3. Roll Skia from aa099ff91e2f to 7d5c206fc873 (6 revisions) (#56541) 

    https://skia.googlesource.com/skia.git/+log/aa099ff91e2f..7d5c206fc873

2024-11-12 [email protected] [infra] Remove Linux NUC9i7QN tasks
2024-11-12 [email protected] Remove log spam about Perfetto being unavailable in Android host builds
2024-11-12 [email protected] Revert "CoreText SkTypeface palette support"
2024-11-12 [email protected] Merge 4 release notes into RELEASE_NOTES.md
2024-11-12 [email protected] Update Skia milestone to 133
2024-11-12 [email protected] Roll vulkan-deps from a2dfb2276ea5 to aa1dd6b24b8b (8 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ce441d9 View commit details
    Browse the repository at this point in the history

  4. Roll Fuchsia Linux SDK from BajfrJuYeyWvnBhuM... to z-cm2nR0aJ4lXfwZ0… 

    …... (#56538)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d23ab21 View commit details
    Browse the repository at this point in the history

  5. Roll Dart SDK from 69170fac244c to 5f42ef8f15d5 (4 revisions) (#56539) 

    https://dart.googlesource.com/sdk.git/+log/69170fac244c..5f42ef8f15d5

2024-11-12 [email protected] Version 3.7.0-136.0.dev
2024-11-12 [email protected] Version 3.7.0-135.0.dev
2024-11-12 [email protected] Version 3.7.0-134.0.dev
2024-11-12 [email protected] Version 3.7.0-133.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0d61080 View commit details
    Browse the repository at this point in the history

  6. [Impeller] prevent no-op backend from throwing exceptions during imag… 

    …e decoding (#56522)

This preveents errors reported in some g3 test cases.
    Jonah Williams authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    ff9931a View commit details
    Browse the repository at this point in the history

  7. macOS: ARC bridge casts for FlutterMetalTexture.user_data (#56518) 

    In `[FlutterSurface asFlutterMetalTexture]` we return a `FlutterMetalTexture` whose `user_data` field holds a `void*` reference to the associated `FlutterSurface`.

For conistency with other parts of the codebase, this now uses ARC bridge casts to perform the additional retain and release of the associated surface rather than CoreFoundation functions `CFBridgingRetain` and `CFBridigingRelease`. In FlutterEngine, for example:
https://github.com/flutter/engine/blob/a672f971c65930f620c7542be58e15669372e16f/shell/platform/darwin/macos/framework/Source/FlutterEngine.mm#L648-L664

Also migrates the code to initialise and immediately return the struct using field designators, and reorders the assignments to be in the declaration order specified in embedder.h as required by the C++ spec.

No changes to tests since this introduces no semantic change.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    a57a4a7 View commit details
    Browse the repository at this point in the history

  8. [Linux] Configure depth and stencil framebuffer attachments needed fo… 

    …r Impeller (#56516)
    @jason-simmons
    jason-simmons authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    08348c9 View commit details
    Browse the repository at this point in the history
Loading