Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8714b54a87c0
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 342a42547822
Choose a head ref
  • 6 commits
  • 9 files changed
  • 4 contributors

Commits on Jul 26, 2024

  1. Roll Fuchsia Test Scripts from clqtZA8cx4GEXwcOe... to dUCMHqU6ihfIFK… 

    …Aw8... (#54130)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-test-scripts-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ebe517b View commit details
    Browse the repository at this point in the history

  2. [Impeller] Implement draw order optimization. (#54067) 

    For each clip scope, draw opaque items in reverse order and
translucent/backdrop-independent items in their original order
afterwards. Clips are treated as translucent by the parent scope.

Respects clips, subpass collapse, and the clear color optimization.
    @bdero
    bdero authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1df62d3 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from e9b8585af6b5 to 06b26a1d51d7 (1 revision) (#54132) 

    https://skia.googlesource.com/skia.git/+log/e9b8585af6b5..06b26a1d51d7

2024-07-25 [email protected] Roll vulkan-deps from 49b5e420b19a to 068847956e41 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d941f08 View commit details
    Browse the repository at this point in the history

  4. Directly use 4x4 matrices with surface textures instead of converting… 

    … to and from the 3x3 variants. (#54126)

SurfaceTextureGetTransformMatrix returns a col-major 4x4 matrix. We used to convert it to a 3x3 matrix. Then when applying the transformation in the shader, I'd convert it back to a 4x4 matrix.

Instead of all this (potentially lossy) flip-flopping, store the matrix just as we get it in 4x4 form and perform the conversion just once if necessary. Today, it is necessary only in the Skia backend. SkM44 already has a converter to convert to and from a 3x3 SkMatrix. So, use that instead of rolling our own.

I spent a lot of time debugging these conversions and transformations because we had rolled our own and the printers seemed to dump in row-major order irrespective of storage order. This caused a lot of confusion.

No change in functionality. Hopefully, the next person debugging transformations has an easier go at this.
    @chinmaygarde
    chinmaygarde authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d69917c View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 06b26a1d51d7 to cd892b576ade (1 revision) (#54134) 

    https://skia.googlesource.com/skia.git/+log/06b26a1d51d7..cd892b576ade

2024-07-26 [email protected] Roll SK Tool from 36cd28553aa8 to 821c531f7514

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    09a2c56 View commit details
    Browse the repository at this point in the history

  6. Reverts "[Impeller] Implement draw order optimization. (#54067)" (#54136 

    )

Reverts: #54067
Initiated by: jonahwilliams
Reason for reverting: disappearing fabs and background color in framework golden tests https://flutter-gold.skia.org/search?issue=152354&crs=github&patchsets=2&corpus=flutter
Original PR Author: bdero

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
For each clip scope, draw opaque items in reverse order and translucent/backdrop-independent items in their original order afterwards. Clips are treated as translucent by the parent scope.

Respects clips, subpass collapse, and the clear color optimization.

### Local new_gallery before/after (iPhone 12 mini):
```
cd ~/projects/flutter/flutter/dev/integration_tests/new_gallery
flutter drive --profile --local-engine-src-path ~/projects/flutter/engine/src --local-engine=ios_profile --local-engine-host=host_profile_arm64 --trace-startup -t test_driver/transitions_perf.dart -d 00008101-000A59A93C10001E
```
![image](https://github.com/user-attachments/assets/7372c128-ca71-44a6-8e6c-b0043025f751)
    @auto-submit
    auto-submit[bot] authored Jul 26, 2024
    Configuration menu
    Copy the full SHA
    342a425 View commit details
    Browse the repository at this point in the history
Loading