Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 86aa01442b5d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bf15bd080314
Choose a head ref
  • 5 commits
  • 9 files changed
  • 5 contributors

Commits on Jun 4, 2019

  1. [scene_host] Cleanup scene_host closures (#9061) 

    Fix null closure warnings, and a possible race condition where the
handle for the view_holder_token is destroyed on the gpu thread.  The
handle's destructor enters the isolate, so it must be destroyed on the
UI thread.

FL-257 #done
FL-269 #done
    @arbreng
    arbreng authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    b304dab View commit details
    Browse the repository at this point in the history

  2. Allow for whitelisted flags to be passed to the Dart VM (#9148) 

    * Allow for whitelisted flags to be passed to the Dart VM

Fixed part of flutter/flutter#32176
    @bkonyi
    bkonyi authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    12f48f7 View commit details
    Browse the repository at this point in the history

  3. Compile the physical_shape_layer_unittests.cc TU. (#9187) 

    This was incorrectly removed by my as I was reworking the GN rules for Fuchsia https://github.com/flutter/engine/pull/8869/files#diff-b6056f6ec9dff658c81f7711f6865e5eL739
    @chinmaygarde
    chinmaygarde authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    7746e2e View commit details
    Browse the repository at this point in the history

  4. Roll src/third_party/skia a4bb020..346f82c (6 commits) (#9188) 

    https://skia.googlesource.com/skia.git
/%2Blog/a4bb02063672..346f82c

git log a4bb020..346f82c --date=short --no-merges --format=%ad %ae %s
2019-06-04 [email protected] print 1/K floats as fractions
2019-06-04 [email protected] move peepholes where they're relevant
2019-06-04 [email protected] [skottie] Initial text range selector support
2019-06-04 [email protected] print SKVM test failures
2019-06-04 [email protected] allow two immediates
2019-06-04 [email protected] Make color initialization version of createBackendTexture public

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    d4c7c30 View commit details
    Browse the repository at this point in the history

  5. Add the key event source, vendorId, and productId from Android (#9186) 

    This adds the key event source from Android so that the framework can differentiate between keyboard events and game controller events. Also added vendor and product ids so that Flutter code can decide to do special processing based on the kind of device, if desired.
    @gspencergoog
    gspencergoog authored Jun 4, 2019
    Configuration menu
    Copy the full SHA
    bf15bd0 View commit details
    Browse the repository at this point in the history
Loading