Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 858d9753453c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: eed12f36f595
Choose a head ref
  • 2 commits
  • 16 files changed
  • 2 contributors

Commits on May 26, 2023

  1. [Impeller] Avoid encoding metal commands while the GPU is unavailable… 

    … when decoding images. (#42349)

Fixes flutter/flutter#126878

This disables device private upload on iOS when backgrounded, and disables mipmap generation when backgrounded.

We don't have a good way to test the core problem in this repo because it only reproduces on physical iOS hardware - simulators don't really care if you do this stuff in the background.

I'll write a devicelab test in the framework to capture this. In the mean time it can be reviewed.

We could consider making the IOManager a shared_ptr instead of having an fml::WeakPtr and that'd clean up some of the extra arguments to engine construction - or we could consider vending the sync switch from impeller::Context unconditionally, but it's pretty iOS specific...
    @dnfield
    dnfield authored May 26, 2023
    Configuration menu
    Copy the full SHA
    882703b View commit details
    Browse the repository at this point in the history

  2. Started executing vulkan unit tests with validation on macos (#42337) 

    fixes flutter/flutter#127634

This PR depends on a buildroot change at flutter/buildroot#737

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored May 26, 2023
    Configuration menu
    Copy the full SHA
    eed12f3 View commit details
    Browse the repository at this point in the history
Loading