Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 84f2fc16e55d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ec7b0ae3599f
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on May 26, 2023

  1. Roll Skia from 1622df035714 to ac897edeb16a (1 revision) (#42348) 

    https://skia.googlesource.com/skia.git/+log/1622df035714..ac897edeb16a

2023-05-26 [email protected] Revert "Omit frame pointers in SkOpts code."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 26, 2023
    Configuration menu
    Copy the full SHA
    4f3566b View commit details
    Browse the repository at this point in the history

  2. [web] - Fix autofill group input ordering (#42268) 

    Ordering of input elements inside of the DOM tree for autofill groups does not reflect the order of the form rendered on screen.  This is causing some issues with password managers and autofill, specifically Bitwarden.

We are currently always appending the currently focused input element to the end of the form. 

This leads to a tree that appears out of order:
<img width="354" alt="Screenshot 2023-05-23 at 2 57 37 PM" src="https://github.com/flutter/engine/assets/110993981/7e90a93f-5522-4482-8fb6-a1607b403d10">

This fix is tracking the position of where the focused input node should be inserted and inserting it there, rather than always at the end of the form.  Once the tree is ordered correctly, Bitwarden's autofill logic works in Flutter forms. 

Tree order after fix:
<img width="502" alt="Screenshot 2023-05-23 at 6 01 05 PM" src="https://github.com/flutter/engine/assets/110993981/bd15a8a1-71f4-4f28-a86e-1903953bf030">

Fixes flutter/flutter#61301
    @htoor3
    htoor3 authored May 26, 2023
    Configuration menu
    Copy the full SHA
    40df5ac View commit details
    Browse the repository at this point in the history

  3. Checkout android and emsdk deps in linux. (#42339) 

    This is to optimize the caches for builders that require those dependencies.

Bug: flutter/flutter#127627

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored May 26, 2023
    Configuration menu
    Copy the full SHA
    ec7b0ae View commit details
    Browse the repository at this point in the history
Loading