Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8440bbe9028a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cd78d213fcc8
Choose a head ref
  • 4 commits
  • 11 files changed
  • 2 contributors

Commits on Jul 15, 2024

  1. Roll Skia from a3c29413cdf0 to fe05596a26ea (1 revision) (#53907) 

    https://skia.googlesource.com/skia.git/+log/a3c29413cdf0..fe05596a26ea

2024-07-15 [email protected] Improve error reporting for failed blend tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    60ed067 View commit details
    Browse the repository at this point in the history

  2. [web] switch to SemanticsAction.focus (attempt 3) (#53689) 

    This relands #53679.

The difference from the previous attempt is in the last commit, which prevents synthetic focus requests from echoing back into the framework. That part broke too many tests in g3 and needs to be revisited.

## Original description

Stop using `SemanticsAction.didGain/LoseAccessibilityFocus` on the web, start using `SemanticsAction.focus`. This is because on the web, a11y focus is not observable, only input focus is. Sending `SemanticsAction.focus` will guarantee that the framework move focus to the respective widget. There currently is no "unfocus" signal, because it seems to be already covered: either another widget gains focus, or an HTML DOM element outside the Flutter view does, both of which have their respective signals already.

More details in the discussion in the issue flutter/flutter#83809.

Fixes flutter/flutter#83809
Fixes flutter/flutter#148285
Fixes flutter/flutter#143337
    @yjbanov
    yjbanov authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f008c51 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from fe05596a26ea to 559a46957250 (7 revisions) (#53909) 

    https://skia.googlesource.com/skia.git/+log/fe05596a26ea..559a46957250

2024-07-15 [email protected] [graphite] Make PaintParamsKeyTest a bit more modular
2024-07-15 [email protected] [graphite] Remove unnecessary premul step in YUV shaders.
2024-07-15 [email protected] [graphite] Add a local-debugging-only PaintParamsKeyTestReduced
2024-07-15 [email protected] [graphite] Add explicit seed and verbose mode to PaintParamsKeyTest
2024-07-15 [email protected] Add ProgramConfig::IsMesh helper.
2024-07-15 [email protected] Remove clamp-to-1 behavior from blend_porter_duff.
2024-07-15 [email protected] [graphite] Encapsulate creation of the KeyContext in the PaintParamsKeyTest

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5b4460d View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 559a46957250 to 476abcbc2e4d (4 revisions) (#53911) 

    https://skia.googlesource.com/skia.git/+log/559a46957250..476abcbc2e4d

2024-07-15 [email protected] Revert "[graphite] Remove unnecessary premul step in YUV shaders."
2024-07-15 [email protected] Reject SkSL programs with identifiers `dmatN` or `dmatNxM`.
2024-07-15 [email protected] Fix overzealous brace elimination in sksl-minify.
2024-07-15 [email protected] Run a graphite native vulkan test tryjob

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 15, 2024
    Configuration menu
    Copy the full SHA
    cd78d21 View commit details
    Browse the repository at this point in the history
Loading