Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 80cd7981043f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bbb1ed00af49
Choose a head ref
  • 3 commits
  • 16 files changed
  • 3 contributors

Commits on Mar 7, 2024

  1. [Impeller] Fix a buffer overrun in ImpellerC reflector resource offse…

    …ts (#51108)
    
    This issue can be reproduced by running the CompilerTest.MustFailDueToMultipleLocationPerStructMember test with ASAN
    
    (The Impeller tests are not yet running with ASAN on CI)
    jason-simmons authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    79d87b4 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from 4a65dfcc70a5 to bf3f9c5f0edb (4 revisions) (#51268)

    skia-flutter-autoroll authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    9a2367f View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Move ANGLE to flutter/third_party (#51270)

    This moves Flutter out of the buildroot's third_party directory and into
    //flutter/third_party and updates all BUILD and gni files.
    
    Issue: flutter/flutter#144786
    Part of: flutter/flutter#67373
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] The odds of this passing on its first CI run is 0%, because
    there's no way the licence script isn't going to have a fit over it, at
    which point I promise on my honour that I will dutifully fix all the
    things it complains about and re-run, probably more than once.
    - [X] This PR fulfils the minimum [Canadian
    Content](https://www.youtube.com/watch?v=h9NMnPm5kXc&list=PLJ7QPuvv91JuoPWrLhqX0zDFUoLdynMEk&index=3)
    regulations mandated by the CRTC.
    - [X] I signed the [CLA].
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    cbracken authored Mar 8, 2024
    Configuration menu
    Copy the full SHA
    bbb1ed0 View commit details
    Browse the repository at this point in the history
Loading