Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7d054abf842c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2a0dd9d2f28e
Choose a head ref
  • 4 commits
  • 8 files changed
  • 3 contributors

Commits on Jul 10, 2023

  1. [Impeller] Don't decompress into device buffer for Vulkan/GLES. (#43493) 

    My observations on the Pixel 6 device are that performing device allocations from multiple threads can dramatically slow down the raster task workload. As a stopgap solution, we can adjust image upload to only touch the device allocator on the IO thread which reduces the parallel access.

This doesn't have any impact on the S10, but locally on the Pixel 6 it is a night and day difference. I am testing using jonahwilliams/forked_gallery and navigating to the Reply demo. This demo has a large number of images, several of which are quite large.

Work towards flutter/flutter#129392

### Before

Page transition is ~4 frames.

![image](https://github.com/flutter/engine/assets/8975114/b6d1c225-060b-4a20-9737-ad668423799a)

### After

Page transition is ~20 frames.

![image](https://github.com/flutter/engine/assets/8975114/5ff1f857-8327-4d04-b40a-3da4a5fc91a4)
    Jonah Williams authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    467e5ea View commit details
    Browse the repository at this point in the history

  2. Roll Skia from c06d7ef5c276 to 89313a8cadab (2 revisions) (#43521) 

    https://skia.googlesource.com/skia.git/+log/c06d7ef5c276..89313a8cadab

2023-07-10 [email protected] Roll vulkan-deps from bcff94480451 to a77b0584c241 (6 revisions)
2023-07-10 [email protected] Make SkParagraph tests run on the CI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    1e1870f View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 89313a8cadab to aad8fbb17d69 (3 revisions) (#43526) 

    https://skia.googlesource.com/skia.git/+log/89313a8cadab..aad8fbb17d69

2023-07-10 [email protected] Experimental SkParagraph API
2023-07-10 [email protected] Revert "[graphite] Reenable tiled image cache size heuristic (take 2)"
2023-07-10 [email protected] Add a tiled-image cache test (take 2)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    4df83ff View commit details
    Browse the repository at this point in the history

  4. [Impeller] Fix Vulkan validation error when there is a blit directed … 

    …at a swapchain image. (#43527)

This shows up in the the aiks test harness in the color wheel with advanced blends.

Fixes flutter/flutter#129853
    @chinmaygarde
    chinmaygarde authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2a0dd9d View commit details
    Browse the repository at this point in the history
Loading