Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 737e6f8ce85e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1ba8fc0765f9
Choose a head ref
  • 4 commits
  • 9 files changed
  • 3 contributors

Commits on Dec 21, 2023

  1. [Windows] Fix incorrect surface manager comment (#49335)

    #24428 attempted to make surface resizing less expensive by using ANGLE's automatic resizing instead of manually destroying and then re-creating the surface. This caused 
    some issues:
    
    1. Flutter's surface size synchronization logic broke: #24682
    2. Resizing frameless windows caused the content to wiggle: flutter/flutter#76465
    
    The second issue caused the automatic resizing change to be reverted. However, the first fix was not reverted resulting in an incorrect comment.
    
    Relanding this resizing performance improvement is tracked by flutter/flutter#79427
    loic-sharma authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b0694c5 View commit details
    Browse the repository at this point in the history
  2. [Impeller] Do not skip rendering when mask blur is zero (#49342)

    The original fix had a bad return value that caused the rendering to abort rather than proceed normally without the blurring.
    
    I also changed the color being used so that the contents would show up in golden diffs which use a white background for unrendered pixels.
    flar authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    0f2b593 View commit details
    Browse the repository at this point in the history
  3. [Impeller] Remove use of private Rect fields from PathBuilder (#49334)

    This change removes the last usages of the Rect internal fields from outside the class, allowing the removal of a `friend` declaration and paving the way to reimplement the Rect methods with ltrb fields.
    flar authored Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6f77dc7 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Fix GetImpellerContext for ShellTestPlatformViewGL (#49337)

    I tried to do this for Vulkan too but hit the limit of my patience for today on debugging why the Vulkan backend was segfaulting on shutdown.
    
    Half of flutter/flutter#140419
    dnfield authored Dec 22, 2023
    Configuration menu
    Copy the full SHA
    1ba8fc0 View commit details
    Browse the repository at this point in the history
Loading