Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 727b4413fe6f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2d8d5ecfe4a8
Choose a head ref
  • 5 commits
  • 8 files changed
  • 3 contributors

Commits on Jun 13, 2023

  1. Remove some trivial deprecated symbol usages in iOS Embedder (#42711) 

    stringWithCString was deprecated in iOS 2.0
UIAccessibilityVoiceOverStatusChanged was deprecated in iOS 11.0

fixes: flutter/flutter#128732
flutter/flutter#128736

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    dd2c57d View commit details
    Browse the repository at this point in the history

  2. Manual roll ICU from 1eea59cabae0 to a2961dc659b4 (0 revision) (#42817) 

    Manual roll requested by [email protected]

https://chromium.googlesource.com/chromium/deps/icu.git/+log/1eea59cabae0..a2961dc659b4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/icu-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in ICU: https://github.com/unicode-org/icu
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9dc974e View commit details
    Browse the repository at this point in the history

  3. Roll Fuchsia Mac SDK from J-zU9HGYXYU5UWJO9... to Cld7-rm6ZmCOO8j-K... ( 

    #42824)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    3b0acf0 View commit details
    Browse the repository at this point in the history

  4. Make validation logs ERROR level (#42825) 

    INFO logs do not show up in normal logging unless an extra flag is passed by the tool (and it is a different flag from the "-v" flag).

This means bug reports that include logs about impeller are missing the validation errors, which makes them harder to triage and dedupe.

Fixes flutter/flutter#128808
    @dnfield
    dnfield authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    9e75866 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 6bdb0ef30cb6 to 6d5dc31d88e2 (7 revisions) (#42790) 

    https://skia.googlesource.com/skia.git/+log/6bdb0ef30cb6..6d5dc31d88e2

2023-06-12 [email protected] [graphite] Fix unused variable warning
in release builds
2023-06-12 [email protected] [graphite] Set more Vulkan pipeline
states.
2023-06-12 [email protected] [graphite] Implement Vulkan Pipeline
input assembly & depth/stencil state setup.
2023-06-12 [email protected] [graphite] Set up vertex attributes in
VulkanGraphicsPipeline.
2023-06-12 [email protected] Reland "[graphite] Use SkSpan for
YUVATextureProxies and YUVABackendTextures."
2023-06-12 [email protected] SkPathBuilder: converts incReserve back to
using reserve()
2023-06-12 [email protected] Remove stub GrBackend* classes

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
[email protected],[email protected],[email protected],[email protected]
on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2d8d5ec View commit details
    Browse the repository at this point in the history
Loading