Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6f8ee9ffd9fa
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4e33a0b47e3d
Choose a head ref
  • 3 commits
  • 9 files changed
  • 3 contributors

Commits on Apr 10, 2024

  1. Migrate FlutterRestorationPlugin, FlutterTextureRegistryRelay, Flutte… 

    …rScreenAndSceneIfLoaded to ARC (#51984)

Smart pointers support ARC as of #47612, and the unit tests were migrated in #48162.

Migrate `FlutterRestorationPlugin`, `FlutterTextureRegistryRelay`, and `UIViewController+FlutterScreenAndSceneIfLoaded` from MRC to ARC.  These files do not themselves import any MRC files, making them leaf nodes in the dependency graph of MRC files.  

Doing a few at a time to make the dependency graph manageable, and to easily revert if this causes retain cycles or other memory management issues.

Part of flutter/flutter#137801.
    @jmagman
    jmagman authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    5b95daf View commit details
    Browse the repository at this point in the history

  2. [Engine] allow --enable-asserts flag to be passed to dart vm in profi… 

    …le mode. (#52029)

Allows flutter/flutter#145729
    Jonah Williams authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    59d5445 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 5bbca5a30653 to fcb5c05acaf2 (1 revision) (#52036) 

    https://skia.googlesource.com/skia.git/+log/5bbca5a30653..fcb5c05acaf2

2024-04-10 [email protected] Manual roll ANGLE from d55464fff7b0 to 392eca60484e (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 10, 2024
    Configuration menu
    Copy the full SHA
    4e33a0b View commit details
    Browse the repository at this point in the history
Loading