Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 67e8b825cc91
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: aa98a9d2e86f
Choose a head ref
  • 4 commits
  • 12 files changed
  • 4 contributors

Commits on Aug 23, 2023

  1. Roll clang with fix for ABI change (#44711)

    In the change here llvm/llvm-project@b653a28, an intentional ABI breaking change was introduced to the clang runtime library for macOS and iOS. That change caused a symbol requiring dynamic linkage to be exposed that triggers iOS App Store checks for usage of private API.
    
    This PR resolves that issue by rolling clang forward and introducing a definition of `_availability_version_check`. The declaration with weak linkage in the clang runtime library [here](https://github.com/llvm/llvm-project/blob/b653a2823fe4b4c9c6d85cfe119f31d8e70c2fa0/compiler-rt/lib/builtins/os_version_check.c#L89) will then be resolved against the definition introduced in this PR. Since the declaration in the clang runtime library will now be resolved by static linking, the Flutter dylib will no longer require it to be dynamically linked, and will therefore not trigger the App Store check for using private API.
    
    The definition of `_availability_version_check` is implemented using the `dlsym` strategy used by the old version of clang [here](https://github.com/llvm/llvm-project/blob/f9ac5575675e4117c2e097a71ad0f02cab92aa97/compiler-rt/lib/builtins/os_version_check.c#L97).
    
    Fixes flutter/flutter#132130
    zanderso authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f2cb42a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c380d1a View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    0e6113a View commit details
    Browse the repository at this point in the history
  2. [Impeller] Fix stencil buffer format selection on Vulkan backend, add…

    … support for D24UnormS8Uint (#45025)
    
    Vulkan was checking for D24 and using D32. This is part of the problem on the Samsung A02. There is still some other problem.
    
    Fixes flutter/flutter#133188
    dnfield authored Aug 24, 2023
    Configuration menu
    Copy the full SHA
    aa98a9d View commit details
    Browse the repository at this point in the history
Loading