Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 66a5761412f9
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 727b4413fe6f
Choose a head ref
  • 10 commits
  • 41 files changed
  • 8 contributors

Commits on Jun 13, 2023

  1. [iOS][Keyboard] Wait vsync on UI thread and update viewport inset to … 

    …avoid jitter. (#42312)

Video for after and before this patch:
[videos.zip](https://github.com/flutter/engine/files/11231756/videos.zip)

- flutter/flutter#120555

The technical problem is: if setViewportMetrics called **before** framework's vsync process callback (rebuild & layout & paint), will cause jitter keyboard animation.So this PR is to keep the time when updateViewportMetrics call to framework side legal.

### Before
![2](https://github.com/flutter/engine/assets/49340347/71198a08-b139-4d6d-87e1-37e536f5d34b)

### After
![1](https://github.com/flutter/engine/assets/49340347/5c9df757-7e39-4855-8c3a-009f5d6438b2)
    @luckysmg
    luckysmg authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    a5ff362 View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from 4dce1093ad94 to 41234fa4b22d (1 revision) (#42810) 

    https://dart.googlesource.com/sdk.git/+log/4dce1093ad94..41234fa4b22d

2023-06-13 [email protected] Version 3.1.0-205.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    82efb52 View commit details
    Browse the repository at this point in the history

  3. Add missing includes (#42812) 

    See https://fxrev.dev/869997.
    @tamird
    tamird authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    815db98 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Null check for the device holder in the Vulkan context des… 

    …tructor (#42821)
    @jason-simmons
    jason-simmons authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    94dc7dd View commit details
    Browse the repository at this point in the history

  5. Added CI step for building with validation layers (#42724) 

    Let's try to make sure the validation layers don't break.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4c2bae7 View commit details
    Browse the repository at this point in the history

  6. [Impeller] Reland attempt Vulkan setup and fallback to GLES. (#42820)

    Jonah Williams authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    983910f View commit details
    Browse the repository at this point in the history

  7. setupDefultFontManager correctly clear out cache (#42178) 

    fixes flutter/flutter#123483

Not entirely sure if this really fix the flake as I can't reproduce locally. My guess to the flake is that the setDefaultfontmgr should only be called once during the life time of the app. The setDefaultfontmgr can be remove at the call site, since it is already called during setup

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @chunhtai
    chunhtai authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b18778c View commit details
    Browse the repository at this point in the history

  8. [Impeller] Added cache for command buffers in vulkan (#42793) 

    issue flutter/flutter#118727

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ae84fee View commit details
    Browse the repository at this point in the history

  9. Roll Dart SDK from 41234fa4b22d to 2465228c0c21 (1 revision) (#42822) 

    https://dart.googlesource.com/sdk.git/+log/41234fa4b22d..2465228c0c21

2023-06-13 [email protected] Version 3.1.0-206.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    20b4eab View commit details
    Browse the repository at this point in the history

  10. Reland "[ios_platform_view] only recycle maskView when the view is ap… 

    …plying mutators #42115" (#42823)

Relands #42115, which was reverted in #42231 due to a crash in the framework test.

The crash is due to a memory management issue that I fixed it in this PR, I also added a scenario test to catch the crash.

fixes: flutter/flutter#125620

See also: orignal PR #41573 for more details.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    727b441 View commit details
    Browse the repository at this point in the history
Loading