Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 623c93554088
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 176e2775c0fc
Choose a head ref
  • 3 commits
  • 11 files changed
  • 3 contributors

Commits on Mar 1, 2023

  1. Simplify FlView (#39467) 

    This PR simplifies the FlView GL interactions. It removes some code paths that were never being used (possibly for future use with platform views?) and complex internal APIs that could be done in a single method call. This is motivated in investigating https://github.com/ubuntu-flutter-community/software/issues/868.

I plan to take this further, since there doesn't seem to be any reason why multiple FlGLArea widgets are used - we can draw all the layers in one widget.

For reviewers - the individual commits aren't particularly interesting, I just did it that way to be sure I wasn't breaking anything along the way and help to diagnose any regressions in the future.

The structural changes that this PR is simplifying came in f94cf14.
    @robert-ancell
    robert-ancell authored Mar 1, 2023
    Configuration menu
    Copy the full SHA
    f37f48d View commit details
    Browse the repository at this point in the history

  2. [Impeller] Remove transient usage from sampled and stored images (#39957 

    )
    @iskakaushik
    iskakaushik authored Mar 1, 2023
    Configuration menu
    Copy the full SHA
    ca173b4 View commit details
    Browse the repository at this point in the history

  3. [Impeller] Improve atlas blending performance by reducing size of sub… 

    …pass. (#39669)

[Impeller] Improve atlas blending performance by reducing size of subpass.
    Jonah Williams authored Mar 1, 2023
    Configuration menu
    Copy the full SHA
    176e277 View commit details
    Browse the repository at this point in the history
Loading