Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 61f0a3fbabbe
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9bb0ece79ae2
Choose a head ref
  • 2 commits
  • 9 files changed
  • 2 contributors

Commits on Sep 23, 2024

  1. Roll Skia from a402d3c60c16 to c20cce6273fb (1 revision) (#55359) 

    https://skia.googlesource.com/skia.git/+log/a402d3c60c16..c20cce6273fb

2024-09-23 [email protected] Simplify SkRect from SkIRect construction in DW ScalerContext

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    e8723f4 View commit details
    Browse the repository at this point in the history

  2. Remove Linux orchestrator builds that only kick off one other build a… 

    …nd wait (#55186)

"Orchestrator" builders are top-level builds that can perform some caching, kick off "drone" sub-builds, and then do things with those build artifacts like run tests, or "generators" that do work on those artifacts.  See more details in https://flutter.dev/go/engine-build-definition-language.

Some orchestrators in [`ci/builders`](https://github.com/flutter/engine/tree/38e37ce9879b2efe4890a8d09f4207dc5686a1bd/ci/builders) _only_ kick off one sub-build.  This is suboptimal because:
1. The orchestrator uses a bot that does nothing except essentially idle.
2. The orchestrator has some overhead, so the orchestrator + single drone sub-build takes longer than just the sub-build run alone.
3. The "drone" sub-build often has a generic name like "Linux Engine Drone" which makes it difficult to keep track of which build is which.

This PR:
1. Hoists a few of these Linux builds into [`ci/builders/standalone`](https://github.com/flutter/engine/tree/38e37ce9879b2efe4890a8d09f4207dc5686a1bd/ci/builders/standalone) which are run as individual builds, and removes the orchestrator.  
2. Swaps the recipe from `engine_v2/engine_v2` (orchestrator) to `engine_v2/builder` (standalone).  
3. Moves the `drone_dimensions` from the orchestrator build json into .ci.yaml.

| Builder    | Before | After |
| -------- | ------- | ------- |
| `Linux clangd`  | [9m & 2 Linux bots](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/6272/overview)  ([drone build](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2689993/overview))  | [6m & 1 Linux bot](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20clangd/6292/overview) |
| `Linux linux_android_emulator_skia_tests_34`  | [29m & 2 Linux bots](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_emulator_skia_tests_34/663/overview) ([drone build](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/2690008/overview))  | [25m & 1 Linux bot](https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20linux_android_emulator_skia_tests_34/678/overview) |

Part of flutter/flutter#155041

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jmagman
    jmagman authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    9bb0ece View commit details
    Browse the repository at this point in the history
Loading