Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 589bde9a95c9
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 28f14e6eec4f
Choose a head ref
  • 11 commits
  • 19 files changed
  • 5 contributors

Commits on Sep 19, 2023

  1. Roll Skia from 744807d740c7 to 1e84aa4509cd (4 revisions) (#46026) 

    https://skia.googlesource.com/skia.git/+log/744807d740c7..1e84aa4509cd

2023-09-19 [email protected] Roll ANGLE from 18f1b3b8e79d to 91ef1f3cfd30 (11 revisions)
2023-09-19 [email protected] Roll Skia Infra from 6e55411b61e1 to 1b17251d0e2c (10 revisions)
2023-09-19 [email protected] Roll Dawn from 02233e019c4e to 5ca21ed72084 (5 revisions)
2023-09-19 [email protected] Roll SK Tool from aea31dd66eb1 to 1b17251d0e2c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4efac42 View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from 5b0e7bda1379 to 8ad823c03f26 (3 revisions) (#46028) 

    https://dart.googlesource.com/sdk.git/+log/5b0e7bda1379..8ad823c03f26

2023-09-19 [email protected] Version 3.2.0-177.0.dev
2023-09-18 [email protected] Version 3.2.0-176.0.dev
2023-09-18 [email protected] Version 3.2.0-175.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    57723a9 View commit details
    Browse the repository at this point in the history

  3. [macOS,iOS] Expose channel buffers 'resize' and 'overflow' control co… ( 

    #44848)

## Description

This PR update the helper function that invokes the control channel 'resize' command (previous implementation relied on a deprecated format). It also adds a similar helper function for the 'overflow' commands exposed by the control channel.

See:

https://github.com/flutter/engine/blob/93e8901490e78c7ba7e319cce4470d9c6478c6dc/lib/ui/channel_buffers.dart#L302-L309

## Related Issue

iOS and macOS implementation for flutter/flutter#132386

Similar implementations:
- Android: #44434
- Linux: #44636

## Tests

Adds two tests.
    @bleroux
    bleroux authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    53430c7 View commit details
    Browse the repository at this point in the history

  4. Add more missing Skia #includes (#46034) 

    Ran into compile errors when refactoring Skia's #includes. This
addresses those

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @kjlubick
    kjlubick authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5fcf808 View commit details
    Browse the repository at this point in the history

  5. Roll Fuchsia Mac SDK from qy5FU4y6sx1FscCpd... to 06g6i7-5u8O-FOTSi... ( 

    #46038)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ab1c8e5 View commit details
    Browse the repository at this point in the history

  6. Roll Dart SDK from 8ad823c03f26 to e7cd697bd0e9 (2 revisions) (#46039) 

    https://dart.googlesource.com/sdk.git/+log/8ad823c03f26..e7cd697bd0e9

2023-09-19 [email protected] Version 3.2.0-179.0.dev
2023-09-19 [email protected] Version 3.2.0-178.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5063098 View commit details
    Browse the repository at this point in the history

  7. Roll Skia from 1e84aa4509cd to 91adc7d289f7 (2 revisions) (#46040) 

    https://skia.googlesource.com/skia.git/+log/1e84aa4509cd..91adc7d289f7

2023-09-19 [email protected] [graphite] Refactor the precompilation SelectOption and AddToKey methods
2023-09-19 [email protected] Add googlefonts CIPD asset to fontations

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    43079d0 View commit details
    Browse the repository at this point in the history

  8. Roll Skia from 91adc7d289f7 to d54cf63f051b (3 revisions) (#46043) 

    https://skia.googlesource.com/skia.git/+log/91adc7d289f7..d54cf63f051b

2023-09-19 [email protected] Add support for matching expected test failures into SkSLTest.
2023-09-19 [email protected] Manual roll Dawn from 5ca21ed72084 to 58dbcccc38b5 (2 revisions)
2023-09-19 [email protected] Manual roll vulkan-deps from 293f55f6d3d0 to 640b7331b244 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c7bb9a2 View commit details
    Browse the repository at this point in the history

  9. [web] DOM objects implement JS object (#46047) 

    Instead of doing `as JSAny` for DOM objects that are defined in static JS interop, let's make them `implements JSObject`?

cc @eyebrowsoffire @srujzs thoughts?
    @mdebbar
    mdebbar authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    58f6fe2 View commit details
    Browse the repository at this point in the history

  10. Update CI to Chrome 117 (#45842)

    @eyebrowsoffire
    eyebrowsoffire authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8d59d5c View commit details
    Browse the repository at this point in the history

  11. Roll Skia from d54cf63f051b to d756a2f5665d (5 revisions) (#46048) 

    https://skia.googlesource.com/skia.git/+log/d54cf63f051b..d756a2f5665d

2023-09-19 [email protected] Enforce IWYU on more src/core files
2023-09-19 [email protected] Migrate Mali 400 test disables into SkSLTest.cpp.
2023-09-19 [email protected] Migrate Adreno test disables into SkSLTest.cpp.
2023-09-19 [email protected] Add way to get GrDirectContext from Ganesh-backed image
2023-09-19 [email protected] [graphite] Use Compose helper to add color filters to the key

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    28f14e6 View commit details
    Browse the repository at this point in the history
Loading