Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 570fec4fa92c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4beaa1195b74
Choose a head ref
  • 3 commits
  • 11 files changed
  • 3 contributors

Commits on Nov 28, 2023

  1. Fix CanonicalizeURL for file schema (#48466)

    The tonic method currently returns `///Users/test/foo` instead of `file:///Users/test/foo`.
    
    Found while looking into making isolate spawning for flutter_tester work.
    dnfield authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    47da8a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Fix the application not disposing by breaking circular references on …

    …quit (#47684)
    
    GtkApplication windows contain a reference back to the application. This
    means the MyApplication object in the Flutter application never
    disposes. We workaround this by removing these references before we
    quit. This occurs for all GTK applications that quit using this method,
    see https://gitlab.gnome.org/GNOME/gtk/-/issues/6190. This may be fixed
    upstream at some point but the proposed workaround should solve the
    problem for all versions and not conflict with any upstream solution.
    
    Fixes flutter/flutter#136582
    robert-ancell authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9ebfc84 View commit details
    Browse the repository at this point in the history
  2. [Impeller] fix descriptor pool recycler test flake. (#48479)

    This test worked by 1) releasing an item to be destructed on a background thead 2) adding a second item to this queue with a waitable event.
    
    The idea being you could wait for the event and that would tell you when 1) was complete. Unfortunately these items are released by being placed into a std::vector, which destroyed in _reverse_ order. Somtimes when the test state was queried the work was done and sometimes it wasn't
    
    To fix this, add a second waitable event that guarantees that both the first event and the original event have finished - because we do not add these event until the first is destructed and we do not add items to the destroy list while it is in progress.
    Jonah Williams authored Nov 29, 2023
    Configuration menu
    Copy the full SHA
    4beaa11 View commit details
    Browse the repository at this point in the history
Loading