Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 53ddbdfc24e5
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4f6ea31d1f25
Choose a head ref
  • 2 commits
  • 23 files changed
  • 2 contributors

Commits on Mar 6, 2024

  1. Manual roll Dart SDK from 50464546d92d to 9ea8813ab4d4 (5 revisions) (#… 

    …51239)

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/50464546d92d..9ea8813ab4d4

2024-03-05 [email protected] Version 3.4.0-200.0.dev
2024-03-05 [email protected] Version 3.4.0-199.0.dev
2024-03-05 [email protected] Version 3.4.0-198.0.dev
2024-03-05 [email protected] Version 3.4.0-197.0.dev
2024-03-04 [email protected] Version 3.4.0-196.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c4b9afa View commit details
    Browse the repository at this point in the history

  2. Reverts "[Impeller] fold memory check into allocator_vk (#51187)" (#5… 

    …1243)

Reverts: #51187
Initiated by: jonahwilliams
Reason for reverting: unexpected benchmark regression

https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller__transition_perf&selected=commit%3D396
Original PR Author: jonahwilliams

Reviewed By: {matanlurey}

This change reverts the following previous change:
Various cleanups to Vulkan allocator implementation:

1. Fixes flutter/flutter#137454
2. Fold device transient cap check into allocator.
3. adds debug tracking for total memory usage in MB (a followup change needs to be made to driver to plumb it through)
4. Small cleanups to mock vulkan so an allocator can be created from it.
5. depth/stencil shouldn't be input attachments.

Part of flutter/flutter#144617
    @auto-submit
    auto-submit[bot] authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4f6ea31 View commit details
    Browse the repository at this point in the history
Loading