Comparing changes

This PR changes the format check on CI to use the command added in #50747. Additionally, while making this change, I noticed that the CI check was not checking the formatting of all files, and that as a result, files were present in the repo with incorrect formatting. I have fixed the formatting and fixed the check to always check all files.

Currently we cache render pass objects to offscreen render targets only. Caching onscreen doesn't work as 1) the render targets are stored on the texture_vk object and 2) the texture_vk object is recreated for each frame (see https://github.com/flutter/engine/blob/main/impeller/renderer/backend/vulkan/surface_vk.cc#L14 ). To make sure the render pass is cached, move the storage to the texture source. part of flutter/flutter#141750

@christopherfujino

…egistrant.java` (#50795) Remove `android/**/GeneratedPluginRegistrant.java` from the global `.gitignore`. This file should never exist in the source tree, locally or on CI, and it existing/being hidden causes lint errors. ## Background Here is what we _think_ happens: - Someone opens `$ENGINE/src/flutter/testing/scenario_app` in VS Code - VS Code picks this up as a "Flutter package", running `flutter packages get` - The Flutter tool generates `../GeneratedPluginRegistrant.java`, thinking this is a Flutter app - The lint error fails on `GeneratedPluginRegistrant` ```txt $ ninja -j100 -C out/android_debug_unopt_arm64/ FAILED: scenario_app/reports/lint-results.xml vpython3 ../../flutter/testing/rules/run_gradle.py /Users/aaclarke/dev/engine/src/flutter/testing/scenario_app/android lint --no-daemon -Pflutter_jar=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/flutter.jar -Pout_dir=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app --project-cache-dir=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app/.gradle --gradle-user-home=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app/.gradle FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':app:lintDebug'. > Lint found errors in the project; aborting build. Fix the issues identified by lint, or create a baseline to see only new errors: ''' android { lint { baseline = file("lint-baseline.xml") } } ''' For more details, see https://developer.android.com/studio/write/lint#snapshot Lint found 1 errors, 0 warnings. First failure: ``` /cc @christopherfujino for any other theories.

#50792) - Close all ImageReaders and Images when we get an onTrimMemory callback. - Remove the first frame fix based around caching the last image displayed because it isn't safe to do on some platforms. Leave a TODO to revisit this. We have seen some reports of platform views not working after an application is backgrounded and then resumed. According to Android GPU folks ImageReader/Image/HardwareBuffers should be valid after an application has been resumed. However on Samsung we know that isn't the case and there are (unconfirmed) reports of it also impacting Pixel devices. Should fix flutter/flutter#142978 and flutter/flutter#139039 Also fixes flutter/flutter#143720

) Dart_TimelineEvent has been deprecated.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Fixes flutter/flutter#106449. Changes it to a static proxy, as the comment recommended. This does mean we will have to update it to override new methods as they are added to the interface when updating the version of the Android sdk we use. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Similar to the framework in flutter/flutter#100576. Closes flutter/flutter#143617.

…ing the GPU surface (#50807) The GPUSurfaceGLImpeller ctor creates an AiksContext/ContentContext, which loads the shader pipelines. If the current thread does not have a GL context and can not execute ReactorGLES operations, then the pipeline futures will not complete. This can cause the raster thread to hang if the reactor has not run and the futures are still incomplete when a rendering task later needs to obtain the pipeline.

…tool (#50805) No issue filed, but was [discussed on discord](https://discord.com/channels/608014603317936148/608021010377080866/1209568840644567091).

#50801) This test is already running in the iOS scenario app: ![DrawSolidBlueScreenTest](https://github.com/flutter/engine/assets/168174/1b499348-f854-4e2d-aa41-f8c6b9ec616d) It should help debug flutter/flutter#143602 by showing if the Android UI is bleeding.

https://skia.googlesource.com/skia.git/+log/9d86359b5fe8..8fa858855820 2024-02-21 [email protected] Create module for skottie's text_shaper only 2024-02-21 [email protected] Enforce IWYU on src/core/Sk[ST].* 2024-02-21 [email protected] [graphite] Limit PathAtlas size to max texture size. 2024-02-21 [email protected] Roll SK Tool from 0c57895d60d7 to 5bd55ab03cb2 2024-02-21 [email protected] Roll ANGLE from e17dd5a40854 to f546983cc8df (10 revisions) 2024-02-21 [email protected] Roll vulkan-deps from 01c25f446238 to d6f39f6bf559 (1 revision) 2024-02-21 [email protected] Roll Skia Infra from cbcd86cee01f to 0c57895d60d7 (7 revisions) 2024-02-21 [email protected] Roll Dawn from 4663ec14a251 to cb331fe0d4f8 (18 revisions) 2024-02-21 [email protected] [skif] Don't restrict layer bounds by desired output for deferred actions 2024-02-21 [email protected] Remove several uses of SkColorFilter::filterColor 2024-02-20 [email protected] Sample from Perlin permutation data at pixel centers. 2024-02-20 [email protected] Replace vec2 variables with scalars in Perlin mix logic. 2024-02-20 [email protected] [bazel] Rewrite Ganesh/Vulkan benchmarks to depend on the modular build. 2024-02-20 [email protected] Disable unreachable-code warning in WGSL. 2024-02-20 [email protected] Remove SkottieShaper.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Feb 21, 2024

This comparison is taking too long to generate.

Uh oh!