Comparing changes

https://skia.googlesource.com/skia.git/+log/ae73baacb793..cbdf09d69efc 2024-01-26 [email protected] Remove AAA/SAA flags from tools If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes flutter/flutter#141571 Shell::Screenshot was impelemnted in a Skia-only way and would crash when invoked. Adds test coverage for the breaking path on iOS that ends up calling `FlutterView drawLayer`.

https://dart.googlesource.com/sdk.git/+log/5636e338e0b9..7337995bc851 2024-01-26 [email protected] Version 3.4.0-78.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/cbdf09d69efc..32f6bff0f193 2024-01-26 [email protected] Roll SK Tool from dcea6056ebed to 2bc97ca55761 2024-01-26 [email protected] Add MotionMark slide to Viewer. 2024-01-26 [email protected] [graphite] Classify orthographic and perspective separately If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/32f6bff0f193..e24124912cc3 2024-01-26 [email protected] Add Arcs to MotionMark slide 2024-01-26 [email protected] Add unit test demonstrating structs in a module. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@cbracken

#50069) Generated by #48903 (`dart ./tools/header_guard_check/bin/main.dart --fix`). As discussed with @cbracken and @jmagman, the guards are not technically needed on the Mac/iOS code, but they (a) do not hurt and (b) still provide value if for some reason `#include` is used instead of `#import` (though I suspect we could try to add that to the tool in the future as well).

…49991) When a view gets disposed of, its rasterizer completely clears up the singleton `PlatformViewManager`. Particularly, it removes all registered platform view factories. This is wrong because the remaining PlatformViews on the page cannot be re-rendered, and the default Platform View factories (used by `pointer_interceptor`, for example), disappear. This PR attempts to preserve the `dispose` logic of the canvaskit rasterizer, without using the `debugClear` method of the `PlatformViewManager` (which is supposedly test-only). ## Issues * Fixes flutter/flutter#142094 ## Tests * Added unit-test * Deployed demo app: https://dit-maps-tests.web.app [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

https://skia.googlesource.com/skia.git/+log/e24124912cc3..c32aa37effcc 2024-01-26 [email protected] Manual roll ANGLE from d0f5a662084b to 6c23a4230b97 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter/flutter#133415. --- This is a prototype I threw together in about 1-2 hours. It enforces and automatically fixes header guards that don't match the [the Google C++ style guide](https://google.github.io/styleguide/cppguide.html#The__define_Guard). For example, here is (trimmed) output at HEAD: ```txt line 5, column 1 of impeller/aiks/picture.h: Unexpected #pragma once ╷ 5 │ #pragma once │ ^^^^^^^^^^^^ ╵ line 5, column 1 of flow/stopwatch.h: Expected #ifndef FLUTTER_FLOW_STOPWATCH_H_ ╷ 5 │ #ifndef FLUTTER_FLOW_INSTRUMENTATION_H_ │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ╵ The following 731 files have invalid header guards: ```

…lkan. (#49946) Adds two new APIs that insert memory barriers for compute -> compute dependencies. ```c++ // |ComputePass| void AddBufferMemoryBarrier() override; // |ComputePass| void AddTextureMemoryBarrier() override; ``` Also makes the ComputePassVK automatically insert a compute -> vertex dependency when encoding. This change is sufficient to let the GPU compute implementation of draw points work on Pixel and Samsung Android devices. For more explaination on these specific barriers, see the documentation added in this PR. Fixes #49946

https://skia.googlesource.com/skia.git/+log/c32aa37effcc..6279c88b9e29 2024-01-26 [email protected] Implement Transform::FindAndDeclareBuiltinStructs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Jan 26, 2024

This comparison is taking too long to generate.

Uh oh!