Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 50bd80773287
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d1e6eb080f08
Choose a head ref
  • 2 commits
  • 19 files changed
  • 2 contributors

Commits on Aug 29, 2023

  1. [web] Make devicePixelRatio ready for multi-view (#44783) 

    This PR moves the source of truth for`devicePixelRatio` to the `EngineFlutterDisplay` singleton.

Main things that this PR is trying to do:
- `EngineFlutterDisplay` is a singleton that represents information about the display.
  - The `devicePixelRatio` can be overriden in tests.
  - The `browserDevicePixelRatio` gets the value directly from the browser and can't be overriden.
- Remove `EngineSingletonFlutterWindow` and incorporate it into `EngineFlutterWindow`.
    @mdebbar
    mdebbar authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    ee71dba View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 4048262b9b21 to b0c1b2868129 (2 revisions) (#45227) 

    https://skia.googlesource.com/skia.git/+log/4048262b9b21..b0c1b2868129

2023-08-29 [email protected] One more SkSwizzlePriv change
2023-08-29 [email protected] [graphite] Account for coverage when deciding to do in-shader blending

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    d1e6eb0 View commit details
    Browse the repository at this point in the history
Loading