Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5019d6da655c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 866b43f656e4
Choose a head ref
  • 8 commits
  • 12 files changed
  • 4 contributors

Commits on Aug 17, 2023

  1. Reenable HardwareBuffer backed Android Platform Views on SDK >= 29 (#… 

    …44790)

- Fix a bug in the SDK < 33 ImageReader construction code path.
- Fix a bug that resulted in references to Images produced by a closed
ImageReader.
- Fix an order of operations bug in ImageReaderPlatformViewRenderTarget
release/finalizer code path.
- Enable HardwareBuffer backed Android Platform Views on SDK >= 29

Manually tested on device rotating and shutting down the app.
    @johnmccutchan
    johnmccutchan authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d259a52 View commit details
    Browse the repository at this point in the history

  2. Fix FlutterInjectorTest assumptions about how the executor service as… 

    …signs tasks to threads (#44775)
    @jason-simmons
    jason-simmons authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    4f967f3 View commit details
    Browse the repository at this point in the history

  3. Roll Fuchsia Mac SDK from VW7WAVPT3Cj5erlae... to Tnp43n_nAR2N0l_gY... ( 

    #44823)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    5a0151a View commit details
    Browse the repository at this point in the history

  4. Add Doxygen doc generation for iOS, macOS, Linux, Windows, and Impell… 

    …er (#43915)

## Description

This starts generating Doxygen docs for iOS, macOS, Linux, Windows, and Impeller. It doesn't remove the existing generation for iOS for now, until we can migrate the API docs to include these instead of those.

## Related Issues
 - flutter/flutter#130999
 - Fixes flutter/flutter#124833
    @gspencergoog
    gspencergoog authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    ffa1904 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from bfd45173e5e3 to e4be2cab442f (3 revisions) (#44824) 

    https://skia.googlesource.com/skia.git/+log/bfd45173e5e3..e4be2cab442f

2023-08-17 [email protected] GraphiteDawn: use Dawn's MSAARenderToSingleSampled feature.
2023-08-17 [email protected] Fill out list of WGSL reserved words.
2023-08-17 [email protected] add skottie image slot support to CanvasKit's ManagedAnimation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    3cdb07c View commit details
    Browse the repository at this point in the history

  6. Roll Skia from e4be2cab442f to 1bec2899ace8 (1 revision) (#44826) 

    https://skia.googlesource.com/skia.git/+log/e4be2cab442f..1bec2899ace8

2023-08-17 [email protected] Roll vulkan-deps from dce9e2d48bec to f84bc95c7dfa (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    145c801 View commit details
    Browse the repository at this point in the history

  7. Roll Dart SDK from 7e4e5796ee99 to 7101eb7569ac (2 revisions) (#44828) 

    https://dart.googlesource.com/sdk.git/+log/7e4e5796ee99..7101eb7569ac

2023-08-17 [email protected] Version 3.2.0-83.0.dev
2023-08-17 [email protected] Version 3.2.0-82.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    714aa98 View commit details
    Browse the repository at this point in the history

  8. Roll Skia from 1bec2899ace8 to 1e62a2d4c429 (1 revision) (#44829) 

    https://skia.googlesource.com/skia.git/+log/1bec2899ace8..1e62a2d4c429

2023-08-17 [email protected] Disable SkSL testing on Dawn + Ganesh.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    866b43f View commit details
    Browse the repository at this point in the history
Loading