Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4d34b6d3da7d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 499eddab8451
Choose a head ref
  • 3 commits
  • 10 files changed
  • 3 contributors

Commits on Apr 20, 2024

  1. Roll Skia from 514d7fc627b3 to 7be6fe3150fc (1 revision) (#52280) 

    https://skia.googlesource.com/skia.git/+log/514d7fc627b3..7be6fe3150fc

2024-04-20 [email protected] Roll vello from 74715ee4650e to 6c1e8b815b1e (19 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    ca496f8 View commit details
    Browse the repository at this point in the history

  2. Remove SkScalarIsFinite from Flutter Engine. (#52270) 

    SkScalarIsFinite is deprecated. Use `std::isfinite` instead.
    @johnstiles-google
    johnstiles-google authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    ca4d5c8 View commit details
    Browse the repository at this point in the history

  3. [et] Fix concurrent modification exception (#52247) 

    We cannot modify the list of build targets as we're iterating over it. Instead of removing non-test/non-executable elements, instead we add executable test targets to a separate testTargets list and use that.

Noticed while working on: flutter/flutter#147071

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    499edda View commit details
    Browse the repository at this point in the history
Loading