Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4a2ac0e51a8f
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d3269d5855a7
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jul 9, 2024

  1. [Impeller] Disable OpenGL dithering by default. (#53768) 

    My expectation was that all toggles were disabled with OpenGL. But the specification states: "The initial value for each capability with the exception of GL_DITHER is GL_FALSE. The initial value for GL_DITHER is GL_TRUE."

The kind of dithering is implementation dependent and our layered OpenGL implementations choose to do nothing when this is enabled (unless extensions like VK_EXT_legacy_dithering are supported). Since, again, per the spec: "As far as OpenGL layering is concerned, no dithering is technically an acceptable algorithm".

But it does have a cost of older hardware where dithering is supported.

This sets the default to match our other backends and get some performance on hardware that does do dithering.
    @chinmaygarde
    chinmaygarde authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d3269d5 View commit details
    Browse the repository at this point in the history
Loading