Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 494fd7fe85a3
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f28eb11e5bd4
Choose a head ref
  • 1 commit
  • 5 files changed
  • 1 contributor

Commits on Aug 31, 2023

  1. [Impeller] copy data out of DlVertices. (#45355) 

    The implementation of DLVerticesGeometry is holding onto a raw ptr that it doesn't own nor does it know that the lifecycle is deterministic. My bad!

This mostly worked (ehhh) until the stopwatch visualizer change. I've confirmed that going back to copying the data fixes the issue with the stopwatch visualizer.
    Jonah Williams authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    f28eb11 View commit details
    Browse the repository at this point in the history
Loading