Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 461d815b48a0
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b1a5d772792f
Choose a head ref
  • 13 commits
  • 34 files changed
  • 4 contributors

Commits on Nov 6, 2023

  1. [Impeller] fix drawVertices dest fast path to apply alpha. (#47695) 

    Part of flutter/flutter#118914

When drawing vertices with a destination blend mode, we need to make sure to forward any alpha component. I introduced some test helpers to allow verification of recorded cmds without goldens.
    Jonah Williams authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6415efd View commit details
    Browse the repository at this point in the history

  2. Roll Dart SDK from 9211fc6406bb to 07d4c9d85a5a (1 revision) (#47709) 

    https://dart.googlesource.com/sdk.git/+log/9211fc6406bb..07d4c9d85a5a

2023-11-06 [email protected] Version 3.3.0-99.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    315495e View commit details
    Browse the repository at this point in the history

  3. [Impeller] Fix EntityPassTarget::Flip with implict MSAA. (#47701) 

    This allows backdrop filters to work with GLES and MSAA.

The swap implementation was only swapping out the resolve texture. But with implicit msaa resolve, the resolve texture and msaa texture are the same - so both need to be swapped.

Fixes flutter/flutter#137301
    Jonah Williams authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5d178b2 View commit details
    Browse the repository at this point in the history

  4. [Impeller] scales blur coverage to match rendered output (#47621) 

    in pursuit of: flutter/flutter#131580

I'm starting to write tests for the new blur, but I wanted to make tests for the old blur to make sure I understood the coverage rules.  I decided to check this in separately while I work on the other blur.

Even though the goal is to delete this class eventually.  Most of this work transfers over to the new blur.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    99fc852 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 77aeee3b81a5 to 2b218381e226 (1 revision) (#47715) 

    https://skia.googlesource.com/skia.git/+log/77aeee3b81a5..2b218381e226

2023-11-06 [email protected] Check for failed buffer creation before removing scratch key.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7a87db2 View commit details
    Browse the repository at this point in the history

  6. Roll Dart SDK from 07d4c9d85a5a to 82731b940e7f (1 revision) (#47717) 

    https://dart.googlesource.com/sdk.git/+log/07d4c9d85a5a..82731b940e7f

2023-11-06 [email protected] Version 3.3.0-100.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    e4e3f1c View commit details
    Browse the repository at this point in the history

  7. Roll Skia from 2b218381e226 to bd5f57c9bd1a (2 revisions) (#47719) 

    https://skia.googlesource.com/skia.git/+log/2b218381e226..bd5f57c9bd1a

2023-11-06 [email protected] [skottie] Use the specified locale for font iteration
2023-11-06 [email protected] Roll Dawn from 558f0dfed768 to 46e9e4cbfdfc (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    331d9bf View commit details
    Browse the repository at this point in the history

  8. Add KeyEventDeviceType to KeyData (#47315) 

    ## Description

Before we deprecate the `RawKeyEvent` code, it needs to provide parity in functionality. One thing that is missing is the `eventSource` field from the `RawKeyEventDataAndroid` class, which provides the device type for the event.

See https://developer.android.com/reference/android/view/InputDevice#SOURCE_KEYBOARD for an example.

This PR implements that support, and sets the source to `KeyEventDeviceType.keyboard` for platforms that don't provide this information. The main thing it does is add the enum `KeyEventDeviceType`, and a new field `KeyData.deviceType`.

## Related Issues
 - flutter/flutter#136419

## Tests
 - Updated tests to also read/write/verify this property.
    @gspencergoog
    gspencergoog authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    cc925b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Roll Skia from bd5f57c9bd1a to 7e3119240ae4 (10 revisions) (#47726) 

    https://skia.googlesource.com/skia.git/+log/bd5f57c9bd1a..7e3119240ae4

2023-11-06 [email protected] Roll vulkan-deps from 122ddb782c61 to 8390e1121511 (1 revision)
2023-11-06 [email protected] [ganesh] Fix dashed circle calculations near 2*pi
2023-11-06 [email protected] Roll debugger-app-base from 1747ffa9b114 to 78b8bb631267
2023-11-06 [email protected] Roll SK Tool from f9ad0db84cbc to e98bb78ac013
2023-11-06 [email protected] [Fontations] Roll Fontations libraries
2023-11-06 [email protected] SkExif: Add support for common tags
2023-11-06 [email protected] Update SKP version
2023-11-06 [email protected] Roll skcms from d0d3db899486 to 42030a771244 (2 revisions)
2023-11-06 [email protected] Roll skottie-base from f97385e8c26a to 65712802736e
2023-11-06 [email protected] Roll shaders-base from 445a3a5c87f5 to acfbe8ab8855

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    41d05a8 View commit details
    Browse the repository at this point in the history

  2. Roll Fuchsia Linux SDK from _vGlgDiKOrtlKrZAP... to NaQb_BU6PSbKXSAoU… 

    …... (#47728)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5dc1996 View commit details
    Browse the repository at this point in the history

  3. Roll Fuchsia Mac SDK from HQfFSkurc6-jKM2jh... to wmM4lS2lYcphFSHPV... ( 

    #47730)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    59478e0 View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from 82731b940e7f to aded6314af29 (1 revision) (#47731) 

    https://dart.googlesource.com/sdk.git/+log/82731b940e7f..aded6314af29

2023-11-07 [email protected] Version 3.3.0-101.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    8b1e63d View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 7e3119240ae4 to 9106e374e08d (1 revision) (#47732) 

    https://skia.googlesource.com/skia.git/+log/7e3119240ae4..9106e374e08d

2023-11-07 [email protected] Roll skcms from 42030a771244 to e9cc5993398f (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b1a5d77 View commit details
    Browse the repository at this point in the history
Loading