Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 45bc4307cda3
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 67dd12f8dfca
Choose a head ref
  • 6 commits
  • 14 files changed
  • 4 contributors

Commits on Sep 14, 2023

  1. Handle external window's WM_CLOSE in lifecycle manager (#45840) 

    Handle the close messages from non-Flutter windows similarly to how we
handle our own, for graceful app exit purposes.

flutter/flutter#131497

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @yaakovschectman
    yaakovschectman authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f5f1a96 View commit details
    Browse the repository at this point in the history

  2. Switch goma to reclient fro standalone targets (#45804) 

    Part of flutter/flutter#132701.
    @keyonghan
    keyonghan authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5512613 View commit details
    Browse the repository at this point in the history

  3. Switch linux_android_debug_engine from goma to reclient (#45345) 

    Part of flutter/flutter#132701.
    @keyonghan
    keyonghan authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    112342e View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 6bc9f5886ddf to 9b7c116ed6c2 (1 revision) (#45853) 

    https://skia.googlesource.com/skia.git/+log/6bc9f5886ddf..9b7c116ed6c2

2023-09-14 [email protected] [skif] FilterResult::draw() operates on SkDevice instead of SkSpecialSurface+SkCanvas

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    8fcdd5a View commit details
    Browse the repository at this point in the history

  5. Remove @pragma('vm:entry-point') annotations on members that aren't a… 

    …ccessed from C++ (#45697)

The `@pragma('vm:entry-point')` annotation serves as an annotation
telling our AOT compiler that the member is needed and cannot be
tree-shaken because it may be accessed from the outside (i.e. C++).

There are seemingly entry-point annotations on members that aren't
actually used from C++.
=> We remove the annotation from those members in this CL.
    @mkustermann
    mkustermann authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3b944b6 View commit details
    Browse the repository at this point in the history

  6. Roll Dart SDK from d25e8d682c8f to 7e4d9f4d8e52 (3 revisions) (#45854) 

    https://dart.googlesource.com/sdk.git/+log/d25e8d682c8f..7e4d9f4d8e52

2023-09-14 [email protected] Version 3.2.0-165.0.dev
2023-09-14 [email protected] Version 3.2.0-164.0.dev
2023-09-14 [email protected] Version 3.2.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 14, 2023
    Configuration menu
    Copy the full SHA
    67dd12f View commit details
    Browse the repository at this point in the history
Loading