Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 455c814fe5de
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 10331db8f748
Choose a head ref
  • 7 commits
  • 16 files changed
  • 5 contributors

Commits on Feb 28, 2024

  1. Make Skia object ostream operators work with unit tests (#51041) 

    Unit tests currently output basic hex dumps of skia objects even though we have ostream operators for many of the common ones. It looks like the operators were created in the wrong namespace (flutter/testing rather than the std namespace). Changing the namespace for the associated `assertions_skia` source files makes them compatible with unit tests that deal with these objects provided that the test files include that header and gn dependency, as verified with the `display_list_unittests` here.
    @flar
    flar authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    3ae7bac View commit details
    Browse the repository at this point in the history

  2. [Impeller] fix render pass depth descriptor. (#51031) 

    Depth+stencil should be treated as the same attachment. Adding more than one d/s attachment in the render pass descriptor seems to be confusing swiftshader.

@bdero 

This fixes things for me locally, lets let CI take a spin
    Jonah Williams authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fa5b02a View commit details
    Browse the repository at this point in the history

  3. Roll Skia from 93f245da0097 to 27171d6a9205 (1 revision) (#51063) 

    https://skia.googlesource.com/skia.git/+log/93f245da0097..27171d6a9205

2024-02-28 [email protected] Fix baseFrequencyY calculation again.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1fe5f70 View commit details
    Browse the repository at this point in the history

  4. [Impeller] Mark subpass framebuffer fetch tests as unsupported on GLES ( 

    #50982)

Currently the GLES backend may claim the framebuffer fetch capability but its implementation does not support the multisample subpass input used in this test.  Do not run this on GLES until there is clarification of the level of framebuffer fetch support intended for the GLES backend.
    @jason-simmons
    jason-simmons authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c11cccf View commit details
    Browse the repository at this point in the history

  5. Roll Dart SDK from 7896a944fe67 to fdf4a62bd07b (1 revision) (#51064) 

    https://dart.googlesource.com/sdk.git/+log/7896a944fe67..fdf4a62bd07b

2024-02-28 [email protected] Version 3.4.0-187.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b42e748 View commit details
    Browse the repository at this point in the history

  6. Roll abseil-cpp to 1db3bdd4eb208bef55c77f22aa94991e52225230 (#51062) 

    Our abseil dependency is a clone of Chromium's, located at:
https://chromium.googlesource.com/chromium/src/third_party/

which is a downstream copy of the source of truth, located at:
https://github.com/abseil/abseil-cpp

This rolls to Chromium commit 185f27671ca28c0f25d9d7a15b6e621f69972706,
then reapplies [email protected]'s commits, in chronological order:
* 9ec8f453a42aad2f11a1760fe4ce6014a124edc2
* f92f9effc89af7692436c3b9fbb3a67f2239d893
* 61833f2c057a2b1993d871e8c51156aed1dd4354

Preparation for: flutter/flutter#144201
Part of: flutter/flutter#67373

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] This patch complies with USDA policy on the use of bovine growth
hormone.
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @cbracken
    cbracken authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    933ac2c View commit details
    Browse the repository at this point in the history

  7. Roll Fuchsia Linux SDK from T1xAi_ww_mWEiDkVN... to ujOkbeYbrC8loPbfR… 

    …... (#51066)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    10331db View commit details
    Browse the repository at this point in the history
Loading