-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: 419fb8c0ab3e
head repository: flutter/engine
compare: b9f9015ff986
- 12 commits
- 62 files changed
- 7 contributors
Commits on Sep 6, 2024
-
Change "there own" to "their own" in Flutter-GPU docs (#54921)
Changed the word "there" to "their" in Flutter GPU doc... which I think is correct, but I could be wrong. Thanks! - [] I listed at least one issue that this PR fixes in the description above. - [] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for c40bc44 - Browse repository at this point
Copy the full SHA c40bc44View commit details -
Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (#55001)
https://skia.googlesource.com/skia.git/+log/6ad117bd2efe..8f62a6a4a299 2024-09-06 [email protected] [graphite] Move SkSL compilation into MtlGraphics|ComputePipeline::Make If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 7f2718d - Browse repository at this point
Copy the full SHA 7f2718dView commit details -
[impeller] fake image for fake tests. (#54974)
Simulator only change to allow toImage and toByteData to not fail when there is no metal context w/ impeller.
Jonah Williams authoredSep 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 0563637 - Browse repository at this point
Copy the full SHA 0563637View commit details -
Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (#55008)
https://skia.googlesource.com/skia.git/+log/8f62a6a4a299..f38ea0134dba 2024-09-06 [email protected] [graphite] Centralize handling of viewport/rtAdjust values 2024-09-06 [email protected] [Vulkan] Fix deletion of fences on failed submits. 2024-09-06 [email protected] [Vulkan] Add AHARDWAREBUFFER_FORMAT_R10G10B10A10_UNORM checks to switch statements. 2024-09-06 [email protected] [graphite] Move lingering Viewer flag handling to SetTestOptions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for e562f3f - Browse repository at this point
Copy the full SHA e562f3fView commit details -
[Impeller] opt into exp canvas. (#54913)
Switch back to new canvas implementation, which allows us to complete the display list/impeller interop arc of work. While we're at it, switch the subpass size rounding logic to round out if there is no image filter. Fixes flutter/flutter#152366 Part of flutter/flutter#142054
Jonah Williams authoredSep 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 397987a - Browse repository at this point
Copy the full SHA 397987aView commit details -
Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (#55013)
https://skia.googlesource.com/skia.git/+log/f38ea0134dba..4786936b4c0c 2024-09-06 [email protected] Revert "[graphite] Swap shape inversion for ClipOps." 2024-09-06 [email protected] Update to Bazel 7 2024-09-06 [email protected] [rust png] Implement `SkPngRustCodec::onGetRepetitionCount`. 2024-09-06 [email protected] [graphite] Add replayTranslation and dstCopyOffset to intrinsic uniforms If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for f0bb98a - Browse repository at this point
Copy the full SHA f0bb98aView commit details -
[DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiv…
…er methods (#54982) Wean the DlOpReceiver interface and implementations off of using the SkScalar, Sk[I]Rect, and SkPoint objects in favor of our own DL/Impeller versions. The start of an ongoing effort to eventually compartmentalize all use of Skia interfaces into a single backend rendering module that is one of 2 semi-pluggable renderers.
Configuration menu - View commit details
-
Copy full SHA for 51d93f8 - Browse repository at this point
Copy the full SHA 51d93f8View commit details -
[skwasm] use temporary RawPaint objects (#54917)
Same as #54818, but for Skwasm. Addresses the `Paint` issue in flutter/flutter#153678 in Skwasm
Configuration menu - View commit details
-
Copy full SHA for 0fad460 - Browse repository at this point
Copy the full SHA 0fad460View commit details -
[multiple] Avoid new
unreachable_switch_defaultwarning. (#54996)The Dart analyzer will soon be changed so that if the `default` clause of a `switch` statement is determined to be unreachable by the exhaustiveness checker, a new warning of type `unreachable_switch_default` will be issued. This parallels the behavior of the existing `unreachable_switch_case` warning, which is issued whenever a `case` clause of a `switch` statement is determined to be unreachable. Before adding the new warning to the analyzer, code in the engine needs to first be updated to eliminate these unreachable `default` clauses, so that the warning won't cause builds to break. For more information, see dart-lang/sdk#54575.
Configuration menu - View commit details
-
Copy full SHA for 8fc5c65 - Browse repository at this point
Copy the full SHA 8fc5c65View commit details -
Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (#55014)
https://skia.googlesource.com/skia.git/+log/4786936b4c0c..06cd203d0607 2024-09-06 [email protected] Move SkMSec out of public API 2024-09-06 [email protected] Replace "exec_tools" with "tools" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 2f1c8b8 - Browse repository at this point
Copy the full SHA 2f1c8b8View commit details -
[engine] reland: always post tasks for platform channel responses. (#…
…55006) Reland of #54975 Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
Jonah Williams authoredSep 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 6dbd735 - Browse repository at this point
Copy the full SHA 6dbd735View commit details
Commits on Sep 7, 2024
-
Reverts "[skwasm] use temporary RawPaint objects (#54917)" (#55018)
Reverts: #54917 Initiated by: jonahwilliams Reason for reverting: failing on framework -> engine roll https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_skwasm_tests_7_last/10571/overview Original PR Author: yjbanov Reviewed By: {eyebrowsoffire} This change reverts the following previous change: Same as #54818, but for Skwasm. Addresses the `Paint` issue in flutter/flutter#153678 in Skwasm
Configuration menu - View commit details
-
Copy full SHA for b9f9015 - Browse repository at this point
Copy the full SHA b9f9015View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 419fb8c0ab3e...b9f9015ff986