Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3d18f65c378a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5cbf96d0a80f
Choose a head ref
  • 3 commits
  • 26 files changed
  • 2 contributors

Commits on Aug 20, 2024

  1. Changes DlColor to support wide gamut colors (#54473) (#54648) 

    relands #54473
issue: flutter/flutter#127855
integration test: #54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with #54415 when it lands in #54567.

## Difference from last attempt

1) The default color is now opaque black, not transparent black (not the issue for revert)
1) Updated a test to send in valid numbers when constructing a color and added asserts to avoid those problems in the future.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    d52fe13 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from b472cacb48d6 to 51d7e221fef0 (2 revisions) (#54656) 

    https://skia.googlesource.com/skia.git/+log/b472cacb48d6..51d7e221fef0

2024-08-20 [email protected] Add [[nodiscard]] to Sk[I]Rect::intersect
2024-08-20 [email protected] Reland "[graphite] Add purge() method to DrawAtlas."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    769db74 View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from 04c57423f90d to 49f655b526c7 (2 revisions) (#54660) 

    https://dart.googlesource.com/sdk.git/+log/04c57423f90d..49f655b526c7

2024-08-20 [email protected] Version 3.6.0-164.0.dev
2024-08-20 [email protected] Version 3.6.0-163.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5cbf96d View commit details
    Browse the repository at this point in the history
Loading