Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3835d975c8b0
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 89a8affdced0
Choose a head ref
  • 2 commits
  • 3 files changed
  • 2 contributors

Commits on Apr 28, 2023

  1. Migrate desktop artifacts to engine v2. (#41599)

    The desktop artifacts are generated using gn+ninja in both the legacy and engine v2 builds. This change is making the engine v2 the primary build.
    
    This change needs to land before https://flutter-review.googlesource.com/c/recipes/+/43340 which is removing the desktop artifacts from the legacy builder to avoid trying to upload the same artifacts multiple times.
    
    There will be some propagation time, 1 or 2 commits where the artifacts will try to be uploaded twice making the legacy Linux Host Engine build fail and recover automatically with the auto-retry.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    godofredoc authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    ceb1722 View commit details
    Browse the repository at this point in the history
  2. Roll Skia from 9867fa253064 to 49412cbee072 (13 revisions) (#41597)

    https://skia.googlesource.com/skia.git/+log/9867fa253064..49412cbee072
    
    2023-04-28 [email protected] Include SkTraceEventCommon.h in SkATrace.cpp
    2023-04-28 [email protected] [graphite] Expand upon VulkanCommandBuffer
    2023-04-28 [email protected] [graphite][compute] Support pre-compiled shader source
    2023-04-28 [email protected] [graphite][compute] Support externally assigned buffer and wg count
    2023-04-28 [email protected] Clearer names for foreground/background text style
    2023-04-28 [email protected] [graphite] Support uniform buffers in ComputeSteps
    2023-04-28 [email protected] Enforce IWYU on src/core/SkA* and select others
    2023-04-28 [email protected] Create dedicated continue_op to handle loop-continue.
    2023-04-28 [email protected] (Manual) Roll Dawn from 664e1e070201 to c755ec54aa80 (19 revisions)
    2023-04-28 [email protected] Enforce IWYU on src/gpu/ganesh/effects
    2023-04-28 [email protected] Remove SkSpecialImage::makeSurface
    2023-04-28 [email protected] Roll vulkan-deps from 14eaf973d52a to 42bf259b43f4 (1 revision)
    2023-04-28 [email protected] Reland "[skif] Context fully controls SkSpecialSurface creation"
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Apr 28, 2023
    Configuration menu
    Copy the full SHA
    89a8aff View commit details
    Browse the repository at this point in the history
Loading