Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 371db85f33d7
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: db2b45bea2c0
Choose a head ref
  • 8 commits
  • 16 files changed
  • 5 contributors

Commits on Jul 9, 2024

  1. [Impeller] Update docs that specify how to select the Impeller backen… 

    …d. (#53788)
    @chinmaygarde
    chinmaygarde authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    786a9f2 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Validation errors in tests cause GTest failures. (#53786) 

    Earlier, this used to take down the entire process. Now, the entire set of failures will be listed instead.
    @chinmaygarde
    chinmaygarde authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    5db8065 View commit details
    Browse the repository at this point in the history

  3. dart:ui - drop deprecated hash functions (#53787) 

    These were deprecated a LONG time ago
    @kevmoo
    kevmoo authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    64db5f4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Impeller really wants premultiplied alpha (#53770) 

    Fixes flutter/flutter#151210 by premultiplying alpha in the rare case we
get straight alpha.
    @jtmcdole
    jtmcdole authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    78c22da View commit details
    Browse the repository at this point in the history

  2. Manual roll Dart SDK from ffc8bb004a64 to dba0dfbd06eb (23 revisions) (… 

    …#53791)

Manual roll requested by [email protected]

https://dart.googlesource.com/sdk.git/+log/ffc8bb004a64..dba0dfbd06eb

2024-07-10 [email protected] Version 3.6.0-22.0.dev
2024-07-09 [email protected] Version 3.6.0-21.0.dev
2024-07-09 [email protected] Version 3.6.0-20.0.dev
2024-07-09 [email protected] Version 3.6.0-19.0.dev
2024-07-09 [email protected] Version 3.6.0-18.0.dev
2024-07-09 [email protected] Version 3.6.0-17.0.dev
2024-07-08 [email protected] Version 3.6.0-16.0.dev
2024-07-08 [email protected] Version 3.6.0-15.0.dev
2024-07-08 [email protected] Version 3.6.0-14.0.dev
2024-07-08 [email protected] Version 3.6.0-13.0.dev
2024-07-05 [email protected] Version 3.6.0-12.0.dev
2024-07-05 [email protected] Version 3.6.0-11.0.dev
2024-07-05 [email protected] Version 3.6.0-10.0.dev
2024-07-05 [email protected] Version 3.6.0-9.0.dev
2024-07-04 [email protected] Version 3.6.0-8.0.dev
2024-07-04 [email protected] Version 3.6.0-7.0.dev
2024-07-04 [email protected] Version 3.6.0-6.0.dev
2024-07-03 [email protected] Version 3.6.0-5.0.dev
2024-07-03 [email protected] Version 3.6.0-4.0.dev
2024-07-03 [email protected] Version 3.6.0-3.0.dev
2024-07-03 [email protected] Version 3.6.0-2.0.dev
2024-07-03 [email protected] Version 3.6.0-1.0.dev
2024-07-02 [email protected] Version 3.6.0-0.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b584e1c View commit details
    Browse the repository at this point in the history

  3. Reverts "web_ui: drop internal hash code library (#53783)" (#53793) 

    Reverts: #53783
Initiated by: jiahaog
Reason for reverting: There are still internal users of these hash functions (b/352191023). Flutter also exports it [here](https://github.com/flutter/flutter/blob/72f83d3237a051a8b1b849abd267d4a4e80ff774/packages/flutter/lib/src/painting/basic_types.dart#L58) so its easy for developers to use them even without importing `dart:ui`. Though it's an easy fix, I'd imagine this to be a breaking change for the OSS ecosystem a
Original PR Author: kevmoo

Reviewed By: {yjbanov}

This change reverts the following previous change:
We moved to dart:core Object functions a while ago
    @auto-submit
    auto-submit[bot] authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e0f1002 View commit details
    Browse the repository at this point in the history

  4. Reverts "dart:ui - drop deprecated hash functions (#53787)" (#53794) 

    Reverts: #53787
Initiated by: jiahaog
Reason for reverting: There are still internal users of these hash functions (b/352191023). Flutter also exports it [here](https://github.com/flutter/flutter/blob/72f83d3237a051a8b1b849abd267d4a4e80ff774/packages/flutter/lib/src/painting/basic_types.dart#L58) so its easy for developers to use them even without importing `dart:ui`. Though it's an easy fix, I'd imagine this to be a breaking change for the OSS ecosystem a
Original PR Author: kevmoo

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
These were deprecated a LONG time ago
    @auto-submit
    auto-submit[bot] authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    0716db4 View commit details
    Browse the repository at this point in the history

  5. [Impeller] Fix markdown formatting for blocks with tips. (#53789) 

    In the previous patch, I had used the incorrect markdown syntax.

Followup for #53671
    @chinmaygarde
    chinmaygarde authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    db2b45b View commit details
    Browse the repository at this point in the history
Loading