Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 331c5769e291
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d97037077963
Choose a head ref
  • 3 commits
  • 5 files changed
  • 3 contributors

Commits on May 17, 2023

  1. [Android] Do not collapse text selection on shift key up (#42075) 

    Fixes flutter/flutter#101569

This block of code was originally introduced in #15560 , but removing it does not have any affect on the software text editing controls in GBoard.

Before this change
* shift + arrow right/left selection would collapse after releasing the shift key. 
* shift + mouse click to expand selection would collapse after releasing the shift key.

After this change
* shift key up no longer collapses the selection.
    @Renzo-Olivares
    Renzo-Olivares authored May 17, 2023
    Configuration menu
    Copy the full SHA
    47c0d03 View commit details
    Browse the repository at this point in the history

  2. [Impelller] fix flickering due to synchronization issues in compute t… 

    …essellator. (#42076)

We must wait until the compute command buffer has completed before its safe to use the contents of that buffer. THis fixes the flickering I've observed when running the unit test locally.

Test only change, no impact to shipped code.
    Jonah Williams authored May 17, 2023
    Configuration menu
    Copy the full SHA
    be62dd6 View commit details
    Browse the repository at this point in the history

  3. Roll Fuchsia Linux SDK from YrEDYUB9NKhirgo5s... to SDKw1RvH0dWiJXERo… 

    …... (#42100)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 17, 2023
    Configuration menu
    Copy the full SHA
    d970370 View commit details
    Browse the repository at this point in the history
Loading