Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2f097cfd3d2d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ca6f5110d9d3
Choose a head ref
  • 3 commits
  • 9 files changed
  • 2 contributors

Commits on Nov 8, 2024

  1. fml: delete unused scoped_policy (#56462) 

    The last usage of this was in fml::ScopedBlock which was deleted in
#56410.

No test changes since this just deletes dead code.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8c871fe View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Roll Dart SDK from 307869c696e8 to ed9a5b1110ae (2 revisions) (#56465) 

    https://dart.googlesource.com/sdk.git/+log/307869c696e8..ed9a5b1110ae

2024-11-08 [email protected] Version 3.7.0-123.0.dev
2024-11-08 [email protected] Version 3.7.0-122.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 9, 2024
    Configuration menu
    Copy the full SHA
    af80892 View commit details
    Browse the repository at this point in the history

  2. iOS: Use fml::CFRef in place of Scoped (#56463) 

    `fml::CFRef` implements the bulk of the operations implemented in the one-off `Scoped` class except with better safety guarantees such as `[[nodiscard]]` on the `Release` method. It doesn't implement the `handle()` method that allows direct writing into the internal storage of the wrapper, but that method is effectively an escape hatch for all the safety guarantees provided by the wrapper, so it seems safer to avoid adding it.

No changes to tests since this includes no semantic changes.

Issue: flutter/flutter#137801

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Nov 9, 2024
    Configuration menu
    Copy the full SHA
    ca6f511 View commit details
    Browse the repository at this point in the history
Loading