Comparing changes

Related to flutter/flutter#114402 At least in the flutter gallery test app, with flutter/gallery#909 reverted - this significantly improves the performance in the Xcode frame debugger. If we wanted to do this for more color sources or filter effects, we need to do much more work to track texture opacity, but this seems like a reasonable and low cost first step. ### Before ![image](https://user-images.githubusercontent.com/8975114/233222371-f33d29ad-c556-4db0-b949-84777bb09307.png) ### After ![image](https://user-images.githubusercontent.com/8975114/233222350-0517d109-cabd-45af-a0af-06b95da2d026.png)

https://skia.googlesource.com/skia.git/+log/ad90b6bd4760..c21e7df194c3 2023-04-19 [email protected] Change Flutter to always use analytic AA

https://dart.googlesource.com/sdk.git/+log/88a3b66b50d6..7d165bd0bb5e 2023-04-19 [email protected] Version 3.1.0-23.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…... (#41357) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/c21e7df194c3..c50081c62219 2023-04-20 [email protected] Roll Skia Infra from 2b944a5cb38c to 8b632f5f2d8d (3 revisions) 2023-04-19 [email protected] Roll vulkan-deps from 4fbe7556fc02 to 2782b5af9734 (2 revisions) 2023-04-19 [email protected] Revert "Always run color space math in full-float within Ganesh" 2023-04-19 [email protected] Revert "Always run color space math in full-float on the GPU (Part 2)" 2023-04-19 [email protected] [graphite] Stub in VulkanGraphicsPipeline. 2023-04-19 [email protected] Always run color space math in full-float on the GPU (Part 2) 2023-04-19 [email protected] Always run color space math in full-float within Ganesh 2023-04-19 [email protected] Clarify where changes to gn_to_bp should be submitted 2023-04-19 [email protected] Add a GN flag 'skia_enable_skvm'. 2023-04-19 [email protected] Restructure Generator::pushConstructorCast to use a switch. 2023-04-19 [email protected] [graphite] Replace BlockReader with ShaderNode trees If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/c50081c62219..80c38970791e 2023-04-20 [email protected] Roll SK Tool from 08883892b342 to 8b632f5f2d8d 2023-04-20 [email protected] Roll ANGLE from 25f843f89e20 to ef20f19165ab (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/80c38970791e..fc09f9b2fb27 2023-04-20 [email protected] Roll vulkan-deps from 2782b5af9734 to c1d27abff170 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://dart.googlesource.com/sdk.git/+log/7d165bd0bb5e..df05e451b79a 2023-04-20 [email protected] Version 3.1.0-25.0.dev 2023-04-20 [email protected] Version 3.1.0-24.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/fc09f9b2fb27..f4609aa2eaba 2023-04-20 [email protected] Add SK_ENABLE_SKVM and SK_ENABLE_SKSL_IN_RASTER_PIPELINE to Bazel. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

#41367) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Closes flutter/flutter#123365 In my [example code](flutter/flutter#123365 (comment)) I'm using `SystemUiOverlayStyle.dark` which has `null` `statusBarColor` by default (_which can be changed via `Change status bar color` button_) in this case we do not override browser's default status bar color. | Old behaviour | New behaviour | | -- | -- | | <video src="https://user-images.githubusercontent.com/8436039/227386349-e30cce47-ffc6-4465-bb30-cd2888f77d32.mp4" /> | <video src="https://user-images.githubusercontent.com/8436039/227580430-a25e57dc-9d5a-43a1-bcb3-3bd8abd753d8.mp4" /> | In case of PWA the when `statusBarColor` is `null` it will use `theme_color` property from `manifest.json` (I don't know from where does flutter generate `manifest.json`). The default status bar color for PWA is: `"theme_color": "#0175C2",` https://github.com/flutter/flutter/blob/f4caee6efbc0b0094f3cee9e31a7486e3d030819/examples/api/web/manifest.json#L7 | Old PWA behaviour | New PWA behaviour | | -- | -- | | <video src="https://user-images.githubusercontent.com/8436039/227607373-79be7294-d9f7-4a45-9014-28720acce0c7.mp4" /> | <video src="https://user-images.githubusercontent.com/8436039/227607329-be16131f-4104-419a-8e16-2b229d73d95e.mp4" /> | [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…BA (#41342) This provides compatibility with BlitCopyTextureToBufferCommandGLES::Encode and glReadPixels (which only guarantees support for RGBA).

This will start uploading the arm artifacts to the production bucket without the experimental namespace. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Apr 20, 2023

This comparison is taking too long to generate.

Uh oh!