Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2d3f0f41b940
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 50f6d98cb8be
Choose a head ref
  • 3 commits
  • 22 files changed
  • 3 contributors

Commits on Oct 22, 2024

  1. Reverts "Copy gen_snapshots using python's shutil.copy, avoid links (#… 

    …55830)" (#56034)

Reverts: #55830
Initiated by: chinmaygarde
Reason for reverting: Incremental builds are broken. flutter/flutter#157367
Original PR Author: aam

Reviewed By: {mraleph, cbracken}

This change reverts the following previous change:
Default implementation of copy does it via hardlink, which seems to be causing issues with Gatekeeper on mac.

BUG=flutter/flutter#154437
    @auto-submit
    auto-submit[bot] authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    78f4ffa View commit details
    Browse the repository at this point in the history

  2. Fix macos xcprivacy manifest copy location (#56010) 

    Cherry-pick the beta branch privacy location fix #55938 back to master so this doesn't regress in the next beta.

This is for flutter/flutter#157016 on master.  Can be merged once the framework test flutter/flutter#157318 merges.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @jmagman
    jmagman authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2fad597 View commit details
    Browse the repository at this point in the history

  3. [Impeller] refactor clip rendering. (#56030) 

    Now that we don't have the entity pass structure, clips can be treated as a kind of structured data and not a generic entity. Doing so lets us simplify some of the clip management and remove some usage of raw pointers. This change also removes the ClipRestoreContents, which are only ever created and then immediately rendered - we can instead replace this with a function.

The ClipCoverageStack now has explicit Clip/Restore methods that internally apply the same logic, but without involving the entity object.

Redo of #55784
    Jonah Williams authored Oct 22, 2024
    Configuration menu
    Copy the full SHA
    50f6d98 View commit details
    Browse the repository at this point in the history
Loading