Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2a48302f6f4e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ad12c5d02a8c
Choose a head ref
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on May 23, 2024

  1. Roll Skia from 7fcb4edbd9b7 to 8af1d36fbccb (1 revision) (#52998) 

    https://skia.googlesource.com/skia.git/+log/7fcb4edbd9b7..8af1d36fbccb

2024-05-23 [email protected] [graphite] Disable D16 on qualcomm devices in protected contexts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 23, 2024
    Configuration menu
    Copy the full SHA
    5ccd363 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 8af1d36fbccb to 60ed6f47af08 (2 revisions) (#52999) 

    https://skia.googlesource.com/skia.git/+log/8af1d36fbccb..60ed6f47af08

2024-05-23 [email protected] [graphite] Remove makeWithCTM from PrecompileShader
2024-05-23 [email protected] Update tolerances for ImageAsyncReadPixels/SurfaceContextWritePixels tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 23, 2024
    Configuration menu
    Copy the full SHA
    96c01fa View commit details
    Browse the repository at this point in the history

  3. Move pictures from deleted canvases to second-to-last canvas instead … 

    …of last. (#51397)

Previously, when the number of display canvases exceeded the maximum amount, we would augment the rendering to reduce the number of canvases to the maximum amount, and move the pictures from the deleted canvases to the last canvas. However, this would cause ugly rendering in cases where pictures would render on top of the platform views they were supposed to be underneath.

This is especially noticeable when reproducing this bug: flutter/flutter#144854

This changes things slightly so that the pictures are moved to the second-to-last remaining canvas, so that platform views always render over the pictures they are supposed to.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @harryterkelsen
    harryterkelsen authored May 23, 2024
    Configuration menu
    Copy the full SHA
    ad12c5d View commit details
    Browse the repository at this point in the history
Loading