Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 240fb460675d
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 49324cd0b678
Choose a head ref
  • 4 commits
  • 26 files changed
  • 3 contributors

Commits on Jul 29, 2024

  1. Revert "Set GLArea.has-alpha = true (#54053)" (#54190) 

    Reason for revert: Regression + no tests. Must have been at the end of a long day, cause I missed the missing test and glaring warning about that.

This reverts commit 0844c0a.

Re-opens flutter/flutter#152154

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @cbracken
    cbracken authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    30e215f View commit details
    Browse the repository at this point in the history

  2. [engine] remove raster stats feature. (#54187) 

    This debugging tool does not give accurate measurements and we've decided to remove it.

See also: flutter/flutter#131941
    Jonah Williams authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    6613428 View commit details
    Browse the repository at this point in the history

  3. [iOS] leak a single overlay layer. (#54189) 

    Leave at least one overlay layer, to work around cases where scrolling platform views under an app bar continually adds and removes an overlay layer. This logic could be removed if flutter/flutter#150646 is fixed.

Fixes flutter/flutter#152266
    Jonah Williams authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1a46ad7 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from efd1d5b127ae to 62e955dbaef0 (5 revisions) (#54194) 

    https://skia.googlesource.com/skia.git/+log/efd1d5b127ae..62e955dbaef0

2024-07-29 [email protected] Allow child effect passing in PipelineStageCodeGenerator.
2024-07-29 [email protected] Specify recipes.cfg in infra_tests.py
2024-07-29 [email protected] Roll shaders-base from 5084439cd9c3 to cb3395657dd9
2024-07-29 [email protected] Roll debugger-app-base from b7ecdc86a7b4 to 5262a9f62fa6
2024-07-29 [email protected] Roll jsfiddle-base from ca44dd6ab7bf to 699f74900f78

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 29, 2024
    Configuration menu
    Copy the full SHA
    49324cd View commit details
    Browse the repository at this point in the history
Loading