Comparing changes

…ction, tests (#50540) Adds more dynamic method lookups in service of flutter/flutter#143105 Moves the TU out to FML so that Impeller can more easily use it. Adds checking on `AHardwareBuffer_getId` so that it checks the return value before returning what is potentially garbage. Adds some smoke tests to make sure these things actually work/look up meaningful symbols. Test is in the shell because we have testing infra for this kind of thing there.

#50533) Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] Relevant Issues are: Design doc link: https://github.com/flutter/website/actions/runs/7560898849/job/20588395967 Design doc: flutter/flutter#141711 Focus in web multiview: flutter/flutter#137443 Platform dispatcher changes: #49841 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Unlike Goma, the local RBE server must be manually started and stopped between each `ninja` build. This PR adds the startup and shutdown before and after `ninja` is run in the build config runner. It also removes the RBE startup logic from the `gn` script, which was the wrong place for it since there was no opportunity for it to shutdown the service. Removing this logic from the `gn` script will not affect CI since the recipes already do the right startup and shutdown, and logic in the `gn` script skipped the now deleted section of code.

The new Inspect library uses InspectSink as described in [RFC-168](https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0168_exposing_inspect_through_inspectsink?hl=en). Additionally it's using the new CPP bindings instead of the deprecated HLCPP bindings. Bug: https://g-issues.fuchsia.dev/issues/320785253 I've verified on a relevant Fuchsia build that the Flutter runner continues to correctly publish Inspect after this change. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing.

https://dart.googlesource.com/sdk.git/+log/5c9e79e66364..dca13675e65e 2024-02-12 [email protected] Version 3.4.0-133.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This makes the view own its EGL surface. This will allow us to support multiple EGL surfaces once the engine supports having multiple views. Some notable changes: 1. EGL surface resizing logic is now entirely in `FlutterWindowsView`. Previously some resizing logic was in the `egl::Manager`, however, the view has to handle resizing failures so this unifies the logic in one place. 2. The `OnEmptyFrameGenerated` and `OnFrameGenerated` now return `false` (aka "don't present") if the surface is invalid. This simplifies the compositor as it no longer needs to check for invalid surfaces 3. This introduces a `ViewModifier` testing helper to allow overriding a view's surface. This isn't strictly necessary, tests can setup a surface by mocking several EGL methods and calling `FlutterWindowsView::CreateRenderSurface()`. However, this is verbose & heavily tied to implementation details. The `ViewModifier` avoids this boilerplate. 4. `CompositorOpenGL`'s initialization now makes the render context current without any render surfaces. Previously it also made the view's surface current, which was unnecessary. Part of flutter/flutter#137267 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Feb 12, 2024

This comparison is taking too long to generate.

Uh oh!