Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 162b2e98c036
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 58c8e30e55ae
Choose a head ref
  • 20 commits
  • 84 files changed
  • 7 contributors

Commits on Oct 26, 2018

  1. iOS Embedding Refactor (#6447) 

    * Create FlutterEngine to manage a Shell to support maintaining execution state across instances of FlutterViewControllers
* Refactor PlatformViewIOS to support adding or removing a FlutterViewController dynamically
* Refactor FlutterDartHeadlessCodeRunner to implement FlutterEngine
* Refactor FlutterViewController to accept a FlutterEngine at initialization or to create one for backwards compatibility; any Shell related responsibilities are now passed through to the Engine instance
* Remove FlutterNavigationController (unused)
* Update all public Objective C doc comments to be consistent and formatable
* Add public documentation to all public headers
    @dnfield
    dnfield authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    2bfb893 View commit details
    Browse the repository at this point in the history

  2. Plumb the iOS PlatformViewsController into flow. (#6603) 

    For flow to manipulate the embedded UIViews during the paint traversal
it needs some hook in PaintContext.
This PR introduces a ViewEmbeder interface that is implemented by the
iOS PlatformViewsController and plumbs it into PaintContext.

The ViewEmbedder interface is mainly a place holder at this point, as
this PR is focused on just the plumbing.
    @amirh
    amirh authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    df85722 View commit details
    Browse the repository at this point in the history

  3. Attach and position embedded UIVIews (#6614)

    @amirh
    amirh authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    f797004 View commit details
    Browse the repository at this point in the history

  4. Update FlutterPlugin.h docs, suppress warning for older API (#6672) 

    * Update FlutterPlugin.h docs, suppress warning for older API
    @dnfield
    dnfield authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    55e1299 View commit details
    Browse the repository at this point in the history

  5. Undefine ERROR in platform_view_layer.cc (#6675) 

    On Windows the ERROR macro is defined by some headers which breaks the
FML_LOG(ERROR).
    @amirh
    amirh authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    6c2a0b3 View commit details
    Browse the repository at this point in the history

  6. Roll buildroot to pick up updates to custom toolchains. (#6674)

    @chinmaygarde
    chinmaygarde authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    505d2a9 View commit details
    Browse the repository at this point in the history

  7. Handle Windows headers defining ERROR to 0 in log levels. (#6677)

    @chinmaygarde
    chinmaygarde authored Oct 26, 2018
    Configuration menu
    Copy the full SHA
    ba8f6aa View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. Roll buildroot to pick up Mac toolchain updates. (#6678)

    @chinmaygarde
    chinmaygarde authored Oct 27, 2018
    Configuration menu
    Copy the full SHA
    c4f5061 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2018

  1. Roll src/third_party/skia 3b79aa3..b53f1f4 (13 commits) (#6679) 

    https://skia.googlesource.com/skia.git/+log/3b79aa3a5ad0..b53f1f46982d


Created with:
  gclient setdep -r src/third_party/skia@b53f1f46982d

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    236661c View commit details
    Browse the repository at this point in the history

  2. Fix inconsistent include syntax (#6680)

    @mehmetf
    mehmetf authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    a1d7cad View commit details
    Browse the repository at this point in the history

  3. Roll src/third_party/skia b53f1f4..38e4fd0 (1 commits) (#6681) 

    https://skia.googlesource.com/skia.git/+log/b53f1f46982d..38e4fd0c5654


Created with:
  gclient setdep -r src/third_party/skia@38e4fd0c5654

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    2f06a53 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Roll src/third_party/skia 38e4fd0..79c9681 (1 commits) (#6682) 

    https://skia.googlesource.com/skia.git/+log/38e4fd0c5654..79c96811863f


Created with:
  gclient setdep -r src/third_party/skia@79c96811863f

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    3dac47e View commit details
    Browse the repository at this point in the history

  2. Roll src/third_party/skia 79c9681..797197a (1 commits) (#6683) 

    https://skia.googlesource.com/skia.git/+log/79c96811863f..797197a772b8


Created with:
  gclient setdep -r src/third_party/skia@797197a772b8

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    7352251 View commit details
    Browse the repository at this point in the history

  3. Roll src/third_party/skia 797197a..1de48d8 (2 commits) (#6684) 

    https://skia.googlesource.com/skia.git/+log/797197a772b8..1de48d8040aa


Created with:
  gclient setdep -r src/third_party/skia@1de48d8040aa

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    c4aa8d3 View commit details
    Browse the repository at this point in the history

  4. Roll src/third_party/skia 1de48d8..6882577 (1 commits) (#6685) 

    https://skia.googlesource.com/skia.git/+log/1de48d8040aa..68825776f4b4


Created with:
  gclient setdep -r src/third_party/skia@68825776f4b4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    ab782fa View commit details
    Browse the repository at this point in the history

  5. Don't populate the external view embedder in PaintContext. (#6686) 

    The platform views embedding is still WIP, and until we dynamically
merge the gpu and platform threads based on the presence of an embedded
view in the scene fetching the view embedder is not thread safe.

This PR essentially disables iOS platform views embedding, we will
re-enable once dynamic thread merging is supported.
    @amirh
    amirh authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    cc686d7 View commit details
    Browse the repository at this point in the history

  6. Roll src/third_party/skia 6882577..ab18c8e (11 commits) (#6688) 

    https://skia.googlesource.com/skia.git/+log/68825776f4b4..ab18c8e6cc20


Created with:
  gclient setdep -r src/third_party/skia@ab18c8e6cc20

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    0e9defb View commit details
    Browse the repository at this point in the history

  7. Roll buildroot to 11a934e (#6687) 

    This reverts a change in buildroot that caused regressions (see flutter/flutter#23678).
    @goderbauer
    goderbauer authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    96bbd2b View commit details
    Browse the repository at this point in the history

  8. Flutter tester default locales (#6689)

    @GaryQian
    GaryQian authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    3b17cfb View commit details
    Browse the repository at this point in the history

  9. Roll src/third_party/skia ab18c8e..d48b7a8 (5 commits) (#6690) 

    https://skia.googlesource.com/skia.git/+log/ab18c8e6cc20..d48b7a881b24


Created with:
  gclient setdep -r src/third_party/skia@d48b7a881b24

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Oct 29, 2018
    Configuration menu
    Copy the full SHA
    58c8e30 View commit details
    Browse the repository at this point in the history
Loading