Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 13a6ce419664
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 61bf47d129bb
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Apr 18, 2024

  1. [Impeller] sorted commonly used default pipelines first (#52231)

    A minor optimization that places default pipelines that are synchronized
    upon in the `InitializeCommonlyUsedShadersIfNeeded` first in the queue
    to be created.
    
    issue: flutter/flutter#145843
    
    sequence diagram of the synchronization:
    
    ![pipeline-seq](https://github.com/flutter/engine/assets/30870216/b70d84fb-2e8e-4d08-a404-ae1434ad03da)
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    gaaclarke authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    eb027b8 View commit details
    Browse the repository at this point in the history
  2. Suppress in-actionable warnings in the iOS profiler. (#52227)

    This is a benign log that is not actionable to the end user. The profiler checker for this and tries again anyway.
    
    Fixes flutter/flutter#116193
    chinmaygarde authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7ec04c9 View commit details
    Browse the repository at this point in the history
  3. Roll Skia from 1af1e478ef85 to edece87ce734 (5 revisions) (#52233)

    https://skia.googlesource.com/skia.git/+log/1af1e478ef85..edece87ce734
    
    2024-04-18 [email protected] Fix crash in nanobench IsFinite benchmark.
    2024-04-18 [email protected] [graphite] Add Image_YUVA::Wrap factory to handle validation
    2024-04-18 [email protected] Add EGL factory
    2024-04-18 [email protected] Update format strings in docs/examples for correct signedness.
    2024-04-18 [email protected] Round up SkSTArray storage to an 8 byte multiple.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f80a686 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    61bf47d View commit details
    Browse the repository at this point in the history
Loading