Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 122c3b382012
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a7899c45791c
Choose a head ref
  • 7 commits
  • 14 files changed
  • 4 contributors

Commits on Apr 21, 2023

  1. Revert "Manual roll skia to d5b4acfb4" (#41381) 

    Reverts #41378

Tests are passing at
https://dart.googlesource.com/sdk/+/7247a1b3b7166c828a0c2e00259ec03fd737d455
    Casey Hillers authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    007a2c6 View commit details
    Browse the repository at this point in the history

  2. Revert "[Impeller] Turned on wide gamut support by default." (#41382) 

    Reverts #39801

`customer: chalk` hit some rendering issues that was narrowed down to this: b/278976014
    @zanderso
    zanderso authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a858ced View commit details
    Browse the repository at this point in the history

  3. Update xcode to 14c18 (#41370) 

    With https://flutter-review.googlesource.com/c/recipes/+/42160, we are
ready to make all tests consistent with xcode 14c18.

Fixes flutter/flutter#125216
    @keyonghan
    keyonghan authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    267f248 View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from 50b96abe9f6f to 4cc2e637a315 (1 revision) (#41387) 

    https://dart.googlesource.com/sdk.git/+log/50b96abe9f6f..4cc2e637a315

2023-04-20 [email protected] Version 3.1.0-27.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    84fcf28 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from f4609aa2eaba to 524ecb58945e (23 revisions) (#41388) 

    https://skia.googlesource.com/skia.git/+log/f4609aa2eaba..524ecb58945e

2023-04-21 [email protected] [skottie] Add option for disabling image asset scaling
2023-04-20 [email protected] Reland "Add a GN flag 'skia_enable_skvm'."
2023-04-20 [email protected] Roll vulkan-deps from c1d27abff170 to 2c49741eda05 (8 revisions)
2023-04-20 [email protected] Cleanup code for SkGlyph underline
2023-04-20 [email protected] Use src.rgba for SkRP execution masks.
2023-04-20 [email protected] graphite: Add test guard for RecorderPriv::resourceCache
2023-04-20 [email protected] Reland "Change Flutter to always use analytic AA"
2023-04-20 [email protected] Remove group_static_libs
2023-04-20 [email protected] (Manual) Roll Dawn from 27c772262048 to 9e9c4560752a (61 revisions)
2023-04-20 [email protected] Revert "Change Flutter to always use analytic AA"
2023-04-20 [email protected] Revert "[skottie] pass slot id to opacity callback"
2023-04-20 [email protected] Create a Raster Pipeline op to exchange src.rgba with memory.
2023-04-20 [email protected] [graphite] Make SkGradientShaderBase own the color and offset bitmap
2023-04-20 [email protected] Reland "Always run color space math in full-float within Ganesh"
2023-04-20 [email protected] Add BAZEL.build file for tools/gpu/mtl
2023-04-20 [email protected] [bazel] Support optional building of Ganesh Metal backend.
2023-04-20 [email protected] Revert "Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM."
2023-04-20 [email protected] Wrap SkShader::program calls with #ifdef SK_ENABLE_SKVM.
2023-04-20 [email protected] graphite-dawn: Use Depth24PlusStencil8 instead of Depth32FloatStencil8.
2023-04-20 [email protected] [graphite] Share boilerplate code in ProxyCacheTests
2023-04-20 [email protected] Add header guards to SkSLRasterPipelineBuilder.h.
2023-04-20 [email protected] Unposion stack allocated memory in arena allocs
2023-04-20 [email protected] Revert "Add a GN flag 'skia_enable_skvm'."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    31a8333 View commit details
    Browse the repository at this point in the history

  6. Roll Fuchsia Mac SDK from 4OrPF9lzqCKGwBLRh... to fMOcI5zn1z0nOrV7s... ( 

    #41389)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a73179f View commit details
    Browse the repository at this point in the history

  7. Roll Skia from 524ecb58945e to 90a93bb0990f (1 revision) (#41390) 

    https://skia.googlesource.com/skia.git/+log/524ecb58945e..90a93bb0990f

2023-04-21 [email protected] Roll Skia Infra from 8b632f5f2d8d to f5a15d80499c (6 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a7899c4 View commit details
    Browse the repository at this point in the history
Loading