Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10ac36c52f08
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 905222c11f06
Choose a head ref
  • 3 commits
  • 18 files changed
  • 2 contributors

Commits on May 10, 2023

  1. Move linux fuchsia engine v2 build to prod. (#41865) 

    This build has been running on prod for a few days already and it is ready to get moved to prod.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored May 10, 2023
    Configuration menu
    Copy the full SHA
    ee6b2f4 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Use separate atlases and shaders for color and alpha (#41780) 

    Creates a separate atlas context and cache for color and alpha bitmap glyphs. Removes SDF shader and uses separate shader for full color glyphs.

Requires #41754

Fixes flutter/flutter#116818
Fixes flutter/flutter#126101

This also fixes #39383 but for light text on a dark background. This problem crops up when we switch to a full color atlas. In this context, the chosen glyph color is important. But with the alpha channel only atlas, its irrelevant.

See diff:

![image](https://user-images.githubusercontent.com/8975114/236598809-f4434764-cd16-4489-9644-4e9a370de7ee.png)

Example app:

```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';

void main() =>
  runApp(
    Container(
      alignment: Alignment.center,
     child: Text(
      '''
 (Unicode Conference)� ا�ذ� س�ع�د �� 10-12 آذار 1997 ب�د��ة ��ا����ت�س� أ��ا��ا. � س�ج�ع ا��ؤت�ر ب�� خبراء �� �ا�ة �طاعات ا�ص�اعة ع�� ا�شب�ة ا�عا���ة ا�تر��ت �������د� ح�ث ستت�� ع�� ا�صع�د�� ا�د��� �ا��ح�� ع�� حد س�اء ��ا�شة سب� استخدا� �����د �� ا��ظ� ا��ائ�ة ����ا �خص ا�تطب��ات ا�حاس�ب�ة� ا�خط�ط� تص��� ا��ص�ص �ا�ح�سبة �تعددة ا��غات.

������������� � � � �''',
textDirection: TextDirection.rtl, style: TextStyle(fontSize: 24, color: Colors.white),
     ),
    ),
  );

```
    Jonah Williams authored May 10, 2023
    Configuration menu
    Copy the full SHA
    688782f View commit details
    Browse the repository at this point in the history

  3. [Impeller] Increase minimum size of alpha glyph atlas. (#41880) 

    Fixes flutter/flutter#122839
Fixes flutter/flutter#126103

Unlike Skia which starts with 2048x2048, I decreased the size of 1024x1024. Now that we'll never switch this to a color bitmap, the memory impact is dramatically lessened.
    Jonah Williams authored May 10, 2023
    Configuration menu
    Copy the full SHA
    905222c View commit details
    Browse the repository at this point in the history
Loading