Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10ac36c52f08
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 406b3546a2ac
Choose a head ref
  • 13 commits
  • 57 files changed
  • 9 contributors

Commits on May 10, 2023

  1. Move linux fuchsia engine v2 build to prod. (#41865) 

    This build has been running on prod for a few days already and it is ready to get moved to prod.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored May 10, 2023
    Configuration menu
    Copy the full SHA
    ee6b2f4 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Use separate atlases and shaders for color and alpha (#41780) 

    Creates a separate atlas context and cache for color and alpha bitmap glyphs. Removes SDF shader and uses separate shader for full color glyphs.

Requires #41754

Fixes flutter/flutter#116818
Fixes flutter/flutter#126101

This also fixes #39383 but for light text on a dark background. This problem crops up when we switch to a full color atlas. In this context, the chosen glyph color is important. But with the alpha channel only atlas, its irrelevant.

See diff:

![image](https://user-images.githubusercontent.com/8975114/236598809-f4434764-cd16-4489-9644-4e9a370de7ee.png)

Example app:

```dart
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';

void main() =>
  runApp(
    Container(
      alignment: Alignment.center,
     child: Text(
      '''
 (Unicode Conference)� ا�ذ� س�ع�د �� 10-12 آذار 1997 ب�د��ة ��ا����ت�س� أ��ا��ا. � س�ج�ع ا��ؤت�ر ب�� خبراء �� �ا�ة �طاعات ا�ص�اعة ع�� ا�شب�ة ا�عا���ة ا�تر��ت �������د� ح�ث ستت�� ع�� ا�صع�د�� ا�د��� �ا��ح�� ع�� حد س�اء ��ا�شة سب� استخدا� �����د �� ا��ظ� ا��ائ�ة ����ا �خص ا�تطب��ات ا�حاس�ب�ة� ا�خط�ط� تص��� ا��ص�ص �ا�ح�سبة �تعددة ا��غات.

������������� � � � �''',
textDirection: TextDirection.rtl, style: TextStyle(fontSize: 24, color: Colors.white),
     ),
    ),
  );

```
    Jonah Williams authored May 10, 2023
    Configuration menu
    Copy the full SHA
    688782f View commit details
    Browse the repository at this point in the history

  3. [Impeller] Increase minimum size of alpha glyph atlas. (#41880) 

    Fixes flutter/flutter#122839
Fixes flutter/flutter#126103

Unlike Skia which starts with 2048x2048, I decreased the size of 1024x1024. Now that we'll never switch this to a color bitmap, the memory impact is dramatically lessened.
    Jonah Williams authored May 10, 2023
    Configuration menu
    Copy the full SHA
    905222c View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from 2cf089614e1c to 7ad028c26344 (2 revisions) (#41882) 

    https://dart.googlesource.com/sdk.git/+log/2cf089614e1c..7ad028c26344

2023-05-09 [email protected] Version 3.1.0-94.0.dev
2023-05-09 [email protected] Version 3.1.0-93.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 10, 2023
    Configuration menu
    Copy the full SHA
    f8550c5 View commit details
    Browse the repository at this point in the history

  5. [web] dialog a11y fixes (#41681) 

    Fixes two issues in dialog accessibility:

* Fixes flutter/flutter#45207 by setting `role="dialog"` on nodes that have both `scopesRoute` and `namesRoute` set. There's no guarantee that this combination of flags is an actual dialog, but it's close enough, and it makes the screen reader announce the appearance of the dialog. Note that `scopesRoute` alone is not sufficient, because Flutter uses it for overlays that are not semantically dialogs, such as dismiss barriers.
* Fixes an issue with focus management, where focus fails to transfer to background content after the dialog is dismissed. This happened because `EngineSemanticsOwner._semanticsTree` retained descendants of parents that were removed. This is benign in many cases. However, for focus this is problematic because the HTML element can go away and come back (losing focus along the way), but its corresponding `SemanticsObject` is never marked as "dirty" and fails to update and request focus.

I'm hoping this is sufficient to fix b/251839784 as well. Will work with the relevant team to find out.
    @yjbanov
    yjbanov authored May 10, 2023
    Configuration menu
    Copy the full SHA
    9504b30 View commit details
    Browse the repository at this point in the history

  6. Roll Skia from 8c936fb9ba8e to 32f4cfc2460b (27 revisions) (#41891) 

    https://skia.googlesource.com/skia.git/+log/8c936fb9ba8e..32f4cfc2460b

2023-05-10 [email protected] Roll ANGLE from c441206103b1 to b0f9c01ec303 (6 revisions)
2023-05-10 [email protected] Roll SK Tool from c4d18f21ffde to 48f97fe0593e
2023-05-10 [email protected] Roll vulkan-deps from 07d94082da0b to d36b7c91621a (7 revisions)
2023-05-10 [email protected] Roll Skia Infra from 0d5474fe31ef to c4d18f21ffde (7 revisions)
2023-05-10 [email protected] Roll SwiftShader from 9ebfb6b54814 to a62e8dbc3467 (1 revision)
2023-05-09 [email protected] SkStrikeCache: Optimize purging of pinned strikes
2023-05-09 [email protected] [Direct3D] Check for null mapped pointer in onReadPixels
2023-05-09 [email protected] Remove temporary analytic AA APIs
2023-05-09 [email protected] Reland "Add support for decoding CICPs in Android"
2023-05-09 [email protected] [graphite] Disable MakeColorSpace_Test in Dawn
2023-05-09 [email protected] fix incorrect check
2023-05-09 [email protected] Switch to SkNoDestructor<T> instead of allocations.
2023-05-09 [email protected] Organize fontations Bazel rules to allow stub impls
2023-05-09 [email protected] [graphite] Add VulkanImageView class.
2023-05-09 [email protected] Force AAA in the canvaskit GMs build script
2023-05-09 [email protected] [graphite] Account for shader blend mode correctly in precomp
2023-05-09 [email protected] Remove DSL-based intrinsic functions.
2023-05-09 [email protected] Remove DSL usage from FunctionCall.
2023-05-09 [email protected] Roll vulkan-deps from 180f3708bf26 to 07d94082da0b (10 revisions)
2023-05-09 [email protected] Update deprecated ShaderModuleWGSLDescriptor.source to .code instead.
2023-05-09 [email protected] Add some mesh (drawVertices) samples
2023-05-09 [email protected] [bazel] //tests/BUILD.bazel: Extract test groups into //tests/testgroups.bzl.
2023-05-09 [email protected] Reland "Add SkNoDestructor<T> class to Skia."
2023-05-09 [email protected] Remove DSL usage from RTAdjust fixup code.
2023-05-09 [email protected] Update Skia Vulkan headers to 1.2.197
2023-05-09 [email protected] Revert "Add support for decoding CICPs in Android"
2023-05-09 [email protected] Revert "Add SkNoDestructor<T> class to Skia."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 10, 2023
    Configuration menu
    Copy the full SHA
    4db1fa4 View commit details
    Browse the repository at this point in the history

  7. Only register top level window message listener upon registering serv… 

    …ice binding (#41733)

Move registering the `WM_CLOSE` message listener in the engine from
initialization to in response to a message sent from `ServiceBinding`
upon its initialization so that we do not intercept window messages when
there is no binding registered.

Addresses flutter/flutter#126033.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Loïc Sharma <[email protected]>
    @yaakovschectman @loic-sharma
    yaakovschectman and loic-sharma authored May 10, 2023
    Configuration menu
    Copy the full SHA
    fea7d0a View commit details
    Browse the repository at this point in the history

  8. Roll Fuchsia Mac SDK from JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... ( 

    #41898)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 10, 2023
    Configuration menu
    Copy the full SHA
    9d1a7b6 View commit details
    Browse the repository at this point in the history

  9. [Impeller] delete special handling of RRect. (#41872) 

    The convex path tessellator is more general purpose than the RRect and shouldn't be any slower. BY removing this class, we make it easier to switch to GPU polyline generation and tessellation for convex shapes.
    Jonah Williams authored May 10, 2023
    Configuration menu
    Copy the full SHA
    80880ab View commit details
    Browse the repository at this point in the history

  10. Migrate mac host clang tidy to engine v2. (#41824) 

    This removes the additional gn command from the ci/lint tool and uses a single gn command.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored May 10, 2023
    Configuration menu
    Copy the full SHA
    0df6740 View commit details
    Browse the repository at this point in the history

  11. Revert "Move linux fuchsia engine v2 build to prod." (#41902) 

    Reverts #41865

Failing a framework test on presubmit:
flutter/flutter#126452
    @zanderso
    zanderso authored May 10, 2023
    Configuration menu
    Copy the full SHA
    892f88d View commit details
    Browse the repository at this point in the history

  12. switch from MockCanvas to DisplayListBuilder in layer unit tests (#41889 

    )

Part of an ongoing set of efforts to address flutter/flutter#106448

The layer unittests have been using a MockCanvas class to record the painting of trees of layers and then testing for the expected output.

A while back a similar mechanism was created to compare DisplayList output and to print out a human-friendly version of the differences found, but it was only used in a few tests written at the time it was created and a few since then.

This is the first in a series of PRs that will move all the rest of the unit tests onto the new DL comparison mechanism, starting with the layer types that just do basic drawing. Some of the remaining layers will require creating new hooks in, for instance, the Texture registry, the performance overlay TextBlob generation, etc.
    @flar
    flar authored May 10, 2023
    Configuration menu
    Copy the full SHA
    8dbffe5 View commit details
    Browse the repository at this point in the history

  13. [web] Re-enable history tests on Safari (#41901) 

    Fixes flutter/flutter#51169
    @mdebbar
    mdebbar authored May 10, 2023
    Configuration menu
    Copy the full SHA
    406b354 View commit details
    Browse the repository at this point in the history
Loading