Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 10a1f9cb74c9
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9dae7b708bda
Choose a head ref
  • 4 commits
  • 15 files changed
  • 3 contributors

Commits on Aug 1, 2023

  1. [iOS] Add darwin_extension_safe flag and use UIScene api when buildin… 

    …g for extensions (#43449)

iOS extensions forbids the usage of UIApplication.sharedApplication. This PR refactors the engine to use UISceneAPI when darwin_extension_safe flag is on. Using UISceneAPI can help avoid the usage of `UIApplication.sharedApplication` as much as possible.
This PR also added a new `_extension_safe` variant for the engine build so all the logic with the `darwin_extension_safe` flag is on can be tested separately.

This PR doesn't enable the engine to build for the extension even when darwin_extension_safe is true.

part of flutter/flutter#124289

There are several issues related to UIApplication life cycle and I manually tested they still work with the scene API:

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d5f6b00 View commit details
    Browse the repository at this point in the history

  2. Roll Clang from ebd0b8a0472b to 07c592048780 (#44224) 

    If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-flutter-engine
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    b6d4384 View commit details
    Browse the repository at this point in the history

  3. Roll Skia from a7a3646c2c8a to d53f7b880651 (6 revisions) (#44226) 

    https://skia.googlesource.com/skia.git/+log/a7a3646c2c8a..d53f7b880651

2023-08-01 [email protected] Reland "Update AutoTArray to always track size"
2023-08-01 [email protected] [debugger-app] use Git from /cipd/bin if present
2023-08-01 [email protected] [skottie] add boolean return value to Slot Manager setters
2023-08-01 [email protected] Fix copy-pasta in KeyHelpers
2023-08-01 [email protected] Reland "[skif] Update MatrixConvolution to use FilterResult"
2023-08-01 [email protected] SkUnicode with libgrapheme implementation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    631cb56 View commit details
    Browse the repository at this point in the history

  4. Made the licenses script output all problems (#44223) 

    fixes: flutter/flutter#131680

verified the behavior in https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8773943493296876561/+/u/test:_licenses_check/stdout

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9dae7b7 View commit details
    Browse the repository at this point in the history
Loading